Giter Site home page Giter Site logo

Comments (5)

cderv avatar cderv commented on July 22, 2024

It seems to be different behavior on different navigator (IE, firefox). Something to do with the slate.js script which use those attributes. I may miss something

from slate.

cderv avatar cderv commented on July 22, 2024

On Firefox, here is what I have when I am not providing an img to google music

-
  name: "google music"
  url: "https://play.google.com/music/listen"
  bg_color: "#ffffff"
  txt_color: "#ff5722"
  tags: ["music"]

capture

Is there a problem with my version of Firefox or with the slate.js file ?

from slate.

gesquive avatar gesquive commented on July 22, 2024

From the look of that screenshot, it looks like the first div is being appended successfully and the second/third divs are not. You can see this part of the code uses the append function.

@cderv can you verify the version of firefox you are using? Also, are there any error messages printed to your console when you refresh?

from slate.

cderv avatar cderv commented on July 22, 2024

I use Firefox 45.8.0. Could it come from this version ?
I find that you use a URL function that is experimental

Developper tool on firefox (F12) says that

  • JS
    • HTML Encoding is not declared and should be
  • CSS
    • some properties are unknown
      • -moz-osx-font-smoothing
      • user-select
      • background-position-x
      • background-position-y
      • background-repeat-x
      • background-repeat-y
  • Journal
    • it display an error err:TypeError: s.append is not a function

I think this error is related to the append you mentionned. In the docs folder js/slate.js contain these lines with an s.append instead of domainDiv.append (see demo code for slate

What do you think is the problem ?

from slate.

gesquive avatar gesquive commented on July 22, 2024

Yup, its the append function. append only works on firefox v49+. I have modified the code to not use append and make it more backwards compatible. A function that requires browsers from late 2016 might be a little too new.

As for the URL function, even though it is experimental. It has been included in browsers since 2013, making it stable enough for me to use.

Thanks for the finding the bug.

from slate.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.