BasketController@update route, method non-existant

[Jamiewarb]

BasketController@update route, method non-existant

[alecritson]

Hey @Jamiewarb

If you look at the definition in the routes file here It actually refers to this controller and method

I couldn't find that definition in routes/api.client.php anywhere

This actually refers to when a user is logged in and they have a basket they want to save, maybe to reuse at a later date without having to add everything in again.

If I'm wrong, please reopen :)

[Jamiewarb]

Hey Alec,

Thanks for the response.

The definition is indeed in routes/api.client.php, on line 45:

$router->resource('baskets', 'Baskets\BasketController', [
    'except' => ['edit', 'create', 'destroy'],
]);

The resource is created, which is creating the update method and PUT/PATCH api/v1/baskets/{basket} route.

Running php artisan route:list | grep "BasketController@update" will show you this route, and that it calls the undefined store method:

$ php artisan route:list | grep "BasketController@update"
| Domain | Method    | URI                                                | Name                                   | Action                                                                           | Middleware                                                                   |
|        | PUT       | api/v1/baskets/saved/{basket}                      |                                        | GetCandy\Api\Http\Controllers\Baskets\SavedBasketController@update               | auth:api,api.currency,api.customer_groups,api.locale,api.tax                 |
|        | PUT|PATCH | api/v1/baskets/{basket}                            | baskets.update                         | GetCandy\Api\Http\Controllers\Baskets\BasketController@update                    | api.client,api.currency,api.customer_groups,api.locale,api.tax

It seems what you linked above is the SavedBasketController, which also has an update method, but if you run the above route:list, you'll see there is one to BasketController defined as well. However BasketController has no method update().

[alecritson]

Hey @Jamiewarb

So in relation to the first route you mentioned api/v1/baskets/saved/{basket} this is defined in my comment above, but api/v1/baskets/{basket} does not have an update method, it looks like it wasn't added to the except array originally.

[Jamiewarb]

Eek, I made a mistake in the original message when I quoted the route api/v1/baskets/saved/{basket}.

I actually meant api/v1/baskets/{basket}. (Sorry!)

Yeah, looks like update wasn't added to the except array as you say. I just wanted to check if this was an accident, or intentional - e.g. will @update be used in the future for updating a specific basket, rather than using store and passing a basket_id param?

[alecritson]

It may well get added in the future, I just did a quick commit though to remove it to avoid confusion for the time being!

[Jamiewarb]

Okay great, thank you!

The candy client also has a Basket()->Put() Job, which I believe goes through to the route we discussed above (and thus the non-existent method). This is what lead me to this problem.

// Jobs/Basket/Put.php
class Put extends AbstractJob
{
    protected function setup()
    {
        $action = 'api/v1/baskets';

        if (is_string($this->params)) {
            $action .= '/' . $this->params;
        }

        $this->addRequest('basket-put', new Request($action, 'PUT', []));

    }
}