count(null) throws error on php >=7.2

[getcandy]

count(null) throws error on php >=7.2

[futdev]

I've also got this problem, any update?

[christophwolff]

+1

[dhonions]

For a quick fix just change:-

if (count($ids)) {
to
if (!empty($ids)) {

in

/src/API/Products/Services/ProductService.php
/src/API/User/Services/UserService.php

[futdev]

@dhonions Yeah that's all good & well, I just hate dirty fixes & hate modifying the repo's inside vendor

[dhonions]

Totally agree - stick it in as a pull-request - I tried, but it disappeared.

[alecritson]

Hey Guys,

We've been working on a bunch of updates that are in the final review stages and we just need to merge them in and set a release. We will be fixing any issues we see on this repo too.

[christophwolff]

I updated the akismet plugin and it was gone.