Comments (10)
Pics and flags in the langswitcher should be implemented as a core plugin feature. It is just my personal approach. I also understand that this is at the moment a no priority thing if i compare importance with other workplaces in grav and gantry.
So please take it as a lp enhancement for future implementation or close it if it should stay a themes creator part of twigging.
from grav-plugin-langswitcher.
The plugin provides a very basic output in its own Twig file (https://github.com/getgrav/grav-plugin-langswitcher/blob/develop/templates/partials/langswitcher.html.twig). The theme can decide to override that, and provide flags or other types of output, by adding a templates/partials/langswitcher.html.twig
file.
from grav-plugin-langswitcher.
Open for a PR if someone wants to add this functionality.
from grav-plugin-langswitcher.
Hi, im agree with Neuronauten that Pics and flags in the langswitcher should be implemented as a core plugin feature.
But im rhinking plugin must be able to display:
- whole word e.g. English
- Lang code e.g. EN
- Flag
- custom image (?)
Reasons why that must be in the plugin:
- No problems with updates.
- No problems with updates!
- Same :)
from grav-plugin-langswitcher.
PRs please :)
from grav-plugin-langswitcher.
english is not my native languadge, please describe, what "PRs" means?
from grav-plugin-langswitcher.
PR = Pull Request
from grav-plugin-langswitcher.
Hi,
Thank for your plugin. As mention above, switching between Text or flags would be a great enhancement.
I'm not developer and i discover grav today. I found https://github.com/lipis/flag-icon-css but i'm not able to insert this project in your plugin.
from grav-plugin-langswitcher.
While I have nothing against people adding options and am aware that this is not always the dev's choice, I'd like to suggest that those wanting flags (or those who may develop the functionality for the PR) check out this article.
It does an excellent job of explaining why flags are not always (except in a pretty specific case) appropriate.
As an:
- Irish man
- who speaks English
- but lives in France
- who always has to pick between UK and US flags
... this is a topic that is close to my heart! ^_^
from grav-plugin-langswitcher.
cleaning up old tickets...
from grav-plugin-langswitcher.
Related Issues (20)
- Plugin doesn't work with include_default_lang: false HOT 1
- Adding x-default fallback? HOT 3
- Plugin generates wrong hreflang code HOT 1
- Session storage "traps" user in a language HOT 5
- switching works fine on localhost but fails when on the server HOT 1
- How to change the Display of the the Languages HOT 1
- Tailing slashes vary HOT 4
- Let the root url be the default language without any language path HOT 3
- Where to add language selector code? HOT 4
- wrong hreflang genereated when run in subdirectory HOT 2
- Big bug - last part of url are not translated to alternate language - the same value of rawRoute() is used for all languages HOT 13
- When `http_accept_language` is set to true, manual switching does not work HOT 3
- Two URLs for additional laguage using slug HOT 14
- Non-existent page: Call to a member function slug() on null HOT 3
- Default language doesn't appear under certain configurations HOT 5
- Full path not being created for other-language pages HOT 22
- If 'default route' is set for a given page, this page’s children become inaccessible via the Langswitcher button -- secondary langauges only HOT 6
- 3.0 update slows down site HOT 1
- link href="alternative" being created for pages that don't exist HOT 1
- Select menu as a configurable display option
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grav-plugin-langswitcher.