Giter Site home page Giter Site logo

Comments (10)

Neuronauten avatar Neuronauten commented on May 11, 2024 5

Pics and flags in the langswitcher should be implemented as a core plugin feature. It is just my personal approach. I also understand that this is at the moment a no priority thing if i compare importance with other workplaces in grav and gantry.
So please take it as a lp enhancement for future implementation or close it if it should stay a themes creator part of twigging.

from grav-plugin-langswitcher.

flaviocopes avatar flaviocopes commented on May 11, 2024

The plugin provides a very basic output in its own Twig file (https://github.com/getgrav/grav-plugin-langswitcher/blob/develop/templates/partials/langswitcher.html.twig). The theme can decide to override that, and provide flags or other types of output, by adding a templates/partials/langswitcher.html.twig file.

from grav-plugin-langswitcher.

flaviocopes avatar flaviocopes commented on May 11, 2024

Open for a PR if someone wants to add this functionality.

from grav-plugin-langswitcher.

pbt39ppc avatar pbt39ppc commented on May 11, 2024

Hi, im agree with Neuronauten that Pics and flags in the langswitcher should be implemented as a core plugin feature.
But im rhinking plugin must be able to display:

  1. whole word e.g. English
  2. Lang code e.g. EN
  3. Flag
  4. custom image (?)

Reasons why that must be in the plugin:

  1. No problems with updates.
  2. No problems with updates!
  3. Same :)

from grav-plugin-langswitcher.

rhukster avatar rhukster commented on May 11, 2024

PRs please :)

from grav-plugin-langswitcher.

pbt39ppc avatar pbt39ppc commented on May 11, 2024

english is not my native languadge, please describe, what "PRs" means?

from grav-plugin-langswitcher.

rhukster avatar rhukster commented on May 11, 2024

PR = Pull Request

from grav-plugin-langswitcher.

 avatar commented on May 11, 2024

Hi,
Thank for your plugin. As mention above, switching between Text or flags would be a great enhancement.
I'm not developer and i discover grav today. I found https://github.com/lipis/flag-icon-css but i'm not able to insert this project in your plugin.

from grav-plugin-langswitcher.

agryson avatar agryson commented on May 11, 2024

While I have nothing against people adding options and am aware that this is not always the dev's choice, I'd like to suggest that those wanting flags (or those who may develop the functionality for the PR) check out this article.

It does an excellent job of explaining why flags are not always (except in a pretty specific case) appropriate.

As an:

  • Irish man
  • who speaks English
  • but lives in France
  • who always has to pick between UK and US flags
    ... this is a topic that is close to my heart! ^_^

from grav-plugin-langswitcher.

rhukster avatar rhukster commented on May 11, 2024

cleaning up old tickets...

from grav-plugin-langswitcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.