Giter Site home page Giter Site logo

[BUG] Break optional scripts about hinode HOT 3 CLOSED

doganulus avatar doganulus commented on August 16, 2024
[BUG] Break optional scripts

from hinode.

Comments (3)

markdumay avatar markdumay commented on August 16, 2024

When submitting a bug, it's helpful to capture the precise error logs, host environment, etc. The bug template contains several sections to consider. Also, please review the following guidelines:

When submitting a bug, please include the exact steps to reproduce the issue. Ideally, use a minimal repo created with the Hinode installation steps for either Hugo or npm (https://gethinode.com/docs/getting-started/introduction/#installation). Add any additional commands and configuration adjustments from there on.

In addition, the latest version of Hinode is v0.23.3. Which exact version is causing the issue?

from hinode.

doganulus avatar doganulus commented on August 16, 2024

Fixed version info as 0.23.3

This commit 7ecc818 refactors partials/optional-scripts to footer/optional-scripts, which I was overriding to add mermaid script at the end of the page.

It is better to continue supporting partials/optional-scripts as a means to add custom user-defined scripts.

from hinode.

markdumay avatar markdumay commented on August 16, 2024

Thanks for the clarification. You're of course free to adapt the Hinode theme in any you want, however, overriding the undocumented optional-scripts file is not endorsed or supported. You might want to consider the guide on how to develop custom modules compatible with Hinode. Alternatively, you can move your custom partial to the new location.

from hinode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.