Giter Site home page Giter Site logo

Comments (4)

mnapoli avatar mnapoli commented on September 2, 2024 1

Hey @pedrodim, thanks for the report. This is indeed something that we need to clarify: because of the way Serverless loads all the plugins and resolves variables, this leads to some circular dependencies with constructs.

Using the initialize hook indeed messes up a few things.

I'll investigate right away if we can solve this specifically. If we can't, I'll document the limitation.

from lift.

pedrodim avatar pedrodim commented on September 2, 2024

Thank you so much!

An idea could be have each construct expose a initialize hook (like they do currently with afterDeploy) so that they could instantiate any dependency or internal config which could use variables there instead on the constructor.

From what I've seem on serverless/serverless#3911 other plugins have solved this by moving any logic that uses variables to a hook, maybe it is something that cannot be possible for all actual constructs but for some this could be a workaround.

from lift.

mnapoli avatar mnapoli commented on September 2, 2024
constructs:
    jobs:
        type: queue
        worker:
            handler: worker.handler
        maxRetries: ${param:maxRetries}
        batchSize: ${env:BATCH_SIZE}

In the example above, ${env:BATCH_SIZE} will be resolved correctly, but not ${param:maxRetries}.

The reason (I suspect) is related to the order in which variables are resolved. I'm still digging into it, I may have a lead.

from lift.

mnapoli avatar mnapoli commented on September 2, 2024

I am working on #31 that should fix this issue.

from lift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.