Possible bug with the newest node version, time calculated wrongly

[getmoro]

Possible bug with the newest node version, time calculated wrongly

[albacoretuna]

Moro is ready for node 10 as in #182

[albacoretuna]

Thanks for the perfect bug report @olpeh

I still can't reproduce it even though I used the same node version.

Can you run the tests and see which one breaks?

npm test

Should run everything.

[olpeh]

I'm also unable to reproduce it anymore. And after that occurence moro has been working without any issues.
However, some of the tests fail, not sure if related.

Ran the tests: 9 tests, 4 failures

Test output

``` ➜ moro git:(master) ✗ nvm current v9.7.1 ➜ moro git:(master) ✗ npm i -g npm /home/olha/.nvm/versions/node/v9.7.1/bin/npm -> /home/olha/.nvm/versions/node/v9.7.1/lib/node_modules/npm/bin/npm-cli.js /home/olha/.nvm/versions/node/v9.7.1/bin/npx -> /home/olha/.nvm/versions/node/v9.7.1/lib/node_modules/npm/bin/npx-cli.js + [email protected] added 63 packages, removed 6 packages and updated 49 packages in 11.658s ➜ moro git:(master) ✗ npm test

[email protected] test /home/olha/projects/moro
cross-env MORO_TEST_MODE='true' ava && bats tests/end-to-end/moro.tests.bats

TAP version 13

test › singleDayReport runs without crashing

ok 1 - test › singleDayReport runs without crashing
Report of all the days:

┌─────────────────────────┬────────────────────────────┐
│ Date │ Work Hours │
├─────────────────────────┼────────────────────────────┤
│ 2017-03-10 │ 7 Hours and 55 Minutes │
├─────────────────────────┼────────────────────────────┤
│ Sum in week 10 │ 7 Hours and 55 Minutes │
└─────────────────────────┴────────────────────────────┘

test › printAllDaysReport runs without crashing

ok 2 - test › printAllDaysReport runs without crashing
Report of all the days:

┌─────────────────────────┬────────────────────────────┐
│ Date │ Work Hours │
├─────────────────────────┼────────────────────────────┤
│ 2017-03-09 │ 7 Hours and 55 Minutes │
├─────────────────────────┼────────────────────────────┤
│ 2017-03-10 │ 7 Hours and 55 Minutes │
├─────────────────────────┼────────────────────────────┤
│ Sum in week 10 │ 15 Hours and 50 Minutes │
├─────────────────────────┼────────────────────────────┤
│ 2017-03-14 │ 8 Hours and 0 Minutes │
├─────────────────────────┼────────────────────────────┤
│ 2017-03-15 │ 8 Hours and 0 Minutes │
├─────────────────────────┼────────────────────────────┤
│ Sum in week 11 │ 16 Hours and 0 Minutes │
└─────────────────────────┴────────────────────────────┘

test › printAllDaysReport with week change runs without crashing

ok 3 - test › printAllDaysReport with week change runs without crashing
There are 3 search results:

┌────────────────────┬───────┬──────────────────────────────────────────────────┐
│ Date │ Time │ Note │
├────────────────────┼───────┼──────────────────────────────────────────────────┤
│ 2017-08-04 │ 17:00 │ #Workrelated │
├────────────────────┼───────┼──────────────────────────────────────────────────┤
│ 2017-08-04 │ 17:30 │ #Workrelated │
├────────────────────┼───────┼──────────────────────────────────────────────────┤
│ 2017-08-04 │ 18:00 │ Other project #related │
└────────────────────┴───────┴──────────────────────────────────────────────────┘

test › printSearchResults runs without crashing

ok 4 - test › printSearchResults runs without crashing

db-tests › db file is created properly

ok 5 - db-tests › db file is created properly
Database file deleted successfully

db-tests › removeDatabase removes db file

ok 6 - db-tests › removeDatabase removes db file
Report of all the days:

┌─────────────────────────┬────────────────────────────┐
│ Date │ Work Hours │
├─────────────────────────┼────────────────────────────┤
│ 2017-03-11 │ 7 Hours and 55 Minutes │
├─────────────────────────┼────────────────────────────┤
│ Sum in week 10 │ 7 Hours and 55 Minutes │
└─────────────────────────┴────────────────────────────┘

db-tests › getFullReport outputs ok results

ok 7 - db-tests › getFullReport outputs ok results

db-tests › createTable makes tables alright

ok 8 - db-tests › createTable makes tables alright

db-tests › updateDatabase inserts and reads correctly

ok 9 - db-tests › updateDatabase inserts and reads correctly

db-tests › calculateWorkHours works

ok 10 - db-tests › calculateWorkHours works
There are 1 search result:

┌────────────────────┬───────┬──────────────────────────────────────────────────┐
│ Date │ Time │ Note │
├────────────────────┼───────┼──────────────────────────────────────────────────┤
│ 2017-08-04 │ 17:00 │ #Workrelated │
└────────────────────┴───────┴──────────────────────────────────────────────────┘

db-tests › getSearchTerm returns the desired note

ok 11 - db-tests › getSearchTerm returns the desired note

1..11

tests 11

pass 11

fail 0

✓ Check that moro report works
✓ moro clear --yes works
✗ moro with no argument, first time should register clock in, and calculate clock out accordingly
(from function assert_success' in file tests/end-to-end/../../node_modules/bats-assert/all.bash, line 25, in test file tests/end-to-end/moro.tests.bats, line 21) assert_success' failed
command failed with exit status 127
output: /home/olha/projects/moro/node_modules/bats/libexec/bats-exec-test: line 58: faketime: command not found
✗ moro with no argument, second time should register clock out
(from function assert_success' in file tests/end-to-end/../../node_modules/bats-assert/all.bash, line 25, in test file tests/end-to-end/moro.tests.bats, line 29) assert_success' failed
command failed with exit status 127
output: /home/olha/projects/moro/node_modules/bats/libexec/bats-exec-test: line 58: faketime: command not found
✓ moro hi 09:00 should adjust clock in at 09:00
✓ moro bye 17:00 should adjust clock out at 17:00
✓ moro break 45 should set break to 45 minutes
✗ moro note should save a note with correct time
(from function assert_success' in file tests/end-to-end/../../node_modules/bats-assert/all.bash, line 25, in test file tests/end-to-end/moro.tests.bats, line 57) assert_success' failed
command failed with exit status 127
output: /home/olha/projects/moro/node_modules/bats/libexec/bats-exec-test: line 58: faketime: command not found
✗ moro search should find the note
(from function assert_contains' in file tests/end-to-end/../../node_modules/bats-assert/all.bash, line 63, from function assert_output_contains' in file tests/end-to-end/../../node_modules/bats-assert/all.bash, line 98,
in test file tests/end-to-end/moro.tests.bats, line 65)
`assert_output_contains 'There are 1 search result:'' failed
expected:
💙 Moro \o/
to contain: There are 1 search result:

9 tests, 4 failures
npm ERR! Test failed. See above for more details.
➜ moro git:(master) ✗ npm --version
5.7.1
➜ moro git:(master) ✗ node --version
v9.7.1

[albacoretuna]

Yes. Node 10 breaks moro, there's a branch with node 10 where tests fail. I'll check when I can.