Giter Site home page Giter Site logo

Comments (7)

carolynvs avatar carolynvs commented on August 26, 2024 2

@dev-drprasad It is still needed. The code where these values are resolved has moved. The code where these values are set is now located here:

https://github.com/deislabs/porter/blob/790e7f97542ef2ae85b04594a145692a630bff26/pkg/config/runtime-manifest.go#L164

I realize that the template paths that I used in the issue were incorrect as well. I said bundle.metadata.name, but it is bundle.name. I'll update the original issue to correct that.

from porter.

carolynvs avatar carolynvs commented on August 26, 2024 1

At the moment, yes. It's out of scope for this issue to change that. We do want to change this so that we can use templating anywhere.

from porter.

carolynvs avatar carolynvs commented on August 26, 2024 1

I recommend not exposing some fields for dependencies. InvocationImage is one of them.

A bundle can have multiple invocation images and it can be selected by the user when they run the bundle. We are still working on the dependencies spec, and invocationImage is one of the values that won't be something that can be determined after the bundle was executed. There may not be much value anyway in knowing the invocation image executed by a dependency (that remains to be seen as we collect use cases and feedback). So for now let's just leave it off.

Thanks for checking! 👍

from porter.

nunix avatar nunix commented on August 26, 2024

oh nice, for my "next crazy evolution" of WSL+CNAB I would need something like:
bundle.dependencies.myOtherBundle.invocationName

as a readonly field of course, as the bundle would be already installed

Looking forward to this one 😈

from porter.

dev-drprasad avatar dev-drprasad commented on August 26, 2024

@carolynvs is this feature still required ? If yes, i would like to pick it up

from porter.

dev-drprasad avatar dev-drprasad commented on August 26, 2024

@carolynvs is substitution/templating possible only in actions ?

from porter.

dev-drprasad avatar dev-drprasad commented on August 26, 2024

@carolynvs I found that Bundle has multiple InvocationImages and there is no name field in InvocationImage struct. Then how authors can do something like bundle.dependencies.mysql.imageName.invocationImage ?

from porter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.