Comments (2)
(I'm assuming this isnt supported in the code, but didnt check)
IMO it makes sense to allow a per-repo key to be stored.
That said, the simplest way to do this is just to create a dummy GitHub account and add the key there. It's far easier to manage than individual deploy keys and the only downside is if it gets compromised you need to rotate all keys. That said, the likelihood of it's key getting compromised and nothing else is so low that it's not a real concern (assuming you're not reusing the key).
from freight.
Yep that is the solution we've gone for and you're right, practically it doesn't make much difference. This issue was just a query as to whether you've considered this and whether it would make sense. The code currently doesn't support this since you define an ssh key in the configuration and that is what gets used for each project.
from freight.
Related Issues (20)
- Deploying a non-existent git ref 500s HOT 1
- Change favicon to indicate busy, finished build states HOT 1
- Use the browser Notifications API to notify of build status changes HOT 4
- timestamps have a hover color but aren't clickable HOT 1
- styles.css needs a hash like vendor.js and app.js HOT 1
- Automatically select application on build pages
- broadcasts snap scroll location to bottom HOT 2
- timestamps selected when copying text HOT 1
- Cancelled tasks remain in "Created" state if not started before cancellation
- feature: put environment in maintenance mode to temporarily reject deploys HOT 2
- feature: tags for builds on docker hub
- Deploy to Heroku button fails
- moha
- Mark deployment as bad/failed after the fact HOT 2
- Ability to preview commits to be deployed, and email authors that their stuff is going out
- Requesting more deployments does not start a new GCP build
- Bad log formatting for failed deployment
- requests.exceptions.JSONDecodeError: [Errno Expecting value] : 0
- Suggest to loosen the dependency on rq
- Error: socket hang up
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freight.