Not sending exceptions through if the sentry url is using self signed certificate

[getsentry]

Not sending exceptions through if the sentry url is using self signed certificate

[foodaemon]

Since i did not got any replies i decided to hack it and add the following configuration. Please let me know if its a good idea.

Created a following method on RavenClient.cs

private static bool ValidateRemoteCertificate(object sender,
X509Certificate certificate,
X509Chain chain,
SslPolicyErrors policyErrors)
{
if (Convert.ToBoolean(ConfigurationManager.AppSettings["IgnoreSslErrors"]))
{
return true;
}
else
{
return policyErrors == SslPolicyErrors.None;
}
}

Added the following line to Send(JsonPacket packet, Dsn dns) method:
ServicePointManager.ServerCertificateValidationCallback += new RemoteCertificateValidationCallback(ValidateRemoteCertificate);

Added the following to the web.config in appSettings
add key="IgnoreSslErrors" value="true"

[asbjornu]

The idea is fine, I'm just not too fond of the implementation. Magic configuration settings like that are both hard to discover and test. It would probably be better with a public property on the RavenClient class, either a Boolean or perhaps a ServerCertificateValidationCallback to provide full control.

[asbjornu]

Since ServicePointManager.ServerCertificateValidationCallback is a static event that applies to all SSL connections within the thread, you can just do the following anywhere inside your application:

ServicePointManager.ServerCertificateValidationCallback += (sender, certificate, chain, policyErrors) =>
{
    if (Convert.ToBoolean(ConfigurationManager.AppSettings["IgnoreSslErrors"]))
        return true;

    return policyErrors == SslPolicyErrors.None;
};

I don't see why we need to include any functionality around this within RavenClient. I'm therefore closing this. Feel free to reopen if you have anything to add. Thanks! 😄