Instrumenting failed AWS SDK requests throws due to AWS's use of UriCreationOptions.DangerousDisablePathAndQueryCanonicalization

[tloten]

Instrumenting failed AWS SDK requests throws due to AWS's use of UriCreationOptions.DangerousDisablePathAndQueryCanonicalization

[jamescrosswell]

Hi @tloten, thanks for the report. I wasn't able to reproduce the error you mentioned using your gist however. I'm just getting a System.Net.Http.HttpRequestException: nodename nor servname provided, or not known (foo.localhost:5236).

Are there some prerequisites perhaps? I have to have some AWS CLI tools or something installed on my machine first, for example?

[tloten]

Hi @jamescrosswell
Sorry about that - on my machine *.localhost resolves the same as localhost, I had no idea it was doing that!

Anyway, can work around that by adding ForcePathStyle = true to the AmazonS3Config. Ala

...
    // Point S3 at ourselves so we can simulate a 500 error happening in S3
    var s3Config = new AmazonS3Config()
    {
        ServiceURL = app.Urls.First(),
        ForcePathStyle = true,
        UseHttp = true,
    };
...

(I've updated the gist too if that's easier)

That just makes the S3Client use path based URLs (e.g. http://baseurl/bucket/key rather than http://bucket.baseurl/key) - again just a workaround to get the S3 client pointed at our dummy endpoint so we can simulate 500's.

Really unsure of the solution here - its quite odd that AWS SDK is using this DangerousDisablePathAndQueryCanonicalization option. And there doesn't seem to be a way to inspect a URI to find out if it's safe to call GetComponents either 🤔

[jamescrosswell]

Anyway, can work around that by adding ForcePathStyle = true to the AmazonS3Config. Ala

Cool, I can reproduce now! That's always the first step 😜