Giter Site home page Giter Site logo

Comments (6)

wereHamster avatar wereHamster commented on May 12, 2024 1

The Sentry.startSpan() API seems to be more honest about what it does, the callback argument is explicitly marked as nullable.

from sentry-javascript.

wereHamster avatar wereHamster commented on May 12, 2024

Wait, what? Importing @sentry/tracing makes it work?!?

import * as Sentry from "@sentry/node"
import "@sentry/tracing"

const transaction = Sentry.startTransaction({
  name: `test`,
})
console.log('tx', transaction)

Still, a function claiming to never return undefined returning undefined is… unexpected.

from sentry-javascript.

lforst avatar lforst commented on May 12, 2024

Generally speaking, I agree, this is stupid. We made a trade-off for tree-shaking.

You must be on a pretty old SDK version though, as when using startTransaction() after init() from @sentry/node should should always return a transaction.

from sentry-javascript.

wereHamster avatar wereHamster commented on May 12, 2024

I tested with 7.94.1, which is the latest version as of now.

https://codesandbox.io/p/devbox/affectionate-breeze-r93zts

from sentry-javascript.

lforst avatar lforst commented on May 12, 2024

@wereHamster You would need to add a call to init(). However, I should add startTransaction and startChild are deprecated and are soon gonna be removed. They are replaced by Sentry.startSpan() which has correct typing.

from sentry-javascript.

getsantry avatar getsantry commented on May 12, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox πŸ₯€

from sentry-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.