Giter Site home page Giter Site logo

Comments (6)

Lms24 avatar Lms24 commented on May 11, 2024 1

yeah that's fine. I was just under the impression that there's no direct replacement for the default init from @sentry/serverless but that's probably fine. Also remembered that we tell folks to use the Node SDK in the Azure functions guide anyway.

from sentry-javascript.

AbhiPrasad avatar AbhiPrasad commented on May 11, 2024 1

On that note, are we sure that serverless environments work with Otel? I guess as long as we're in a Node-compatible runtime they should work but not sure how well we investigated this yet.

With CJS they should work pretty fine! But we need to investigate esm (also the serverless packages use monkeypatching require right now, that will break).

I'm gonna move forward with Option 2 - splitting the package up! Created a tasklist to reflect the work.

from sentry-javascript.

mydea avatar mydea commented on May 11, 2024

generally sounds good to me - should we still have a (generic?) serverless package? is there anything that could be in there? What about non-aws/gcp serverless environments, could they/would they so far have used the serverless package?

from sentry-javascript.

Lms24 avatar Lms24 commented on May 11, 2024

Agreed, sounds like a good change! Should the AWS/GCP packages inherit from @sentry/serverless which in turn continues to be based on @sentry/node?

On that note, are we sure that serverless environments work with Otel? I guess as long as we're in a Node-compatible runtime they should work but not sure how well we investigated this yet.

from sentry-javascript.

lforst avatar lforst commented on May 11, 2024

@mydea @Lms24 I don't particularly see the value behind a generic @sentry/serverless package. What would be in there? So far any other serverless envs would have just used the Node pkg.

I think purely splitting it up into provider-specific packages is the way to go. Let's kill @sentry/serverless.

from sentry-javascript.

mydea avatar mydea commented on May 11, 2024

If we don't have any "generic" serverless code (that could not also just live in core) then yes, let's delete it!

from sentry-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.