Giter Site home page Giter Site logo

Comments (7)

mpranjic24 avatar mpranjic24 commented on May 10, 2024 1

So we've just released v7.112.2, where we hopefully actually have a full fix for your problem - sorry about the confusion! Gonna leave this open this time until I've got confirmation that the issue is actually solved 😅

From what I can see, beforeStartSpan indeed gets called now 👍

Also, in the big "envelope/..." request I can see that the transaction property got changed in 2 places 👍

from sentry-javascript.

mydea avatar mydea commented on May 10, 2024

Hey, thanks for writing in! Hmm, this seems like a bug to me - we'll look into it!

from sentry-javascript.

AbhiPrasad avatar AbhiPrasad commented on May 10, 2024

Fix released with https://github.com/getsentry/sentry-javascript/releases/tag/7.111.0 - please upgrade and give it a try!

from sentry-javascript.

mpranjic24 avatar mpranjic24 commented on May 10, 2024

Unfortunately it doesn't seem to work, @AbhiPrasad. Nothing gets logged. On a side note, before the fix I could make it work with:

// @ts-expect-error: ignore TypeScript
      beforeNavigate(options: { name: string }) {
        ...
     }

That actually produced some console logs and in Chrome network view I could see that the transaction name got updated.

Now, it seems that it doesn't work at all.

from sentry-javascript.

mydea avatar mydea commented on May 10, 2024

I will look into it, it seems that something is really off there, sorry about that!

from sentry-javascript.

mydea avatar mydea commented on May 10, 2024

So we've just released v7.112.2, where we hopefully actually have a full fix for your problem - sorry about the confusion!
Gonna leave this open this time until I've got confirmation that the issue is actually solved 😅

from sentry-javascript.

s1gr1d avatar s1gr1d commented on May 10, 2024

This seems to be fixed, so I am closing this 👍

from sentry-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.