Giter Site home page Giter Site logo

Comments (4)

SBoudrias avatar SBoudrias commented on April 28, 2024

Hi @mattrobenolt, tested this build this morning and this was working great on my app.

Although, I'm concerned by the fact you infer if define is a function, then require is a function. If I'm correct, only RequireJS AMD loader use the require function, other like curl, lsjs and dojo may break (didn't test it though). But anyway, I guess the point is mostly that inferring is a - most of the time - bad thing. Any though?

from sentry-javascript.

mattrobenolt avatar mattrobenolt commented on April 28, 2024

I'll look into this today with the other AMD libs and see if it'll hurt. Thanks for the feedback. :)

And, this is probably the direction things are going to go: #69 FYI

from sentry-javascript.

mattrobenolt avatar mattrobenolt commented on April 28, 2024

Ok, so according to the spec, you're right. It's not required to exist. I'll adjust this. http://wiki.commonjs.org/wiki/Modules/AsynchronousDefinition

from sentry-javascript.

mattrobenolt avatar mattrobenolt commented on April 28, 2024

This will be a plugin. So closing this.

from sentry-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.