Comments (18)
I've got tons of errors I ignore. Why is this being removed? For example - I was continually getting an error that I finally traced back to be some random Firefox plugin that generated a spurious error. There was nothing I could do about it - so I added it to ignoreErrors.
from sentry-javascript.
I reverted this deprecation warning. It's just a bad idea. :)
Thanks for the input guys!
from sentry-javascript.
I'll yank with 1.1
from sentry-javascript.
@jeremyhaile Would you be able to get around it with ignoreUrls
instead? If not, I'll keep it around. I was under the impression that nobody used this and it was just adding bloat. :)
from sentry-javascript.
Hmm - good question. If I add a URL like "http://static.ak.facebook.com/" to ignoreUrls, does it ignore all errors that come from any directory/file that starts with that URL?
from sentry-javascript.
ignoreUrls
takes an array of regex patterns. So you can do whatever you want. :)
from sentry-javascript.
@jeremyhaile Specifically: https://github.com/getsentry/raven-js/blob/master/src/raven.js#L374
from sentry-javascript.
OK - I'm going to try deleting ignoreErrors from our configuration and see what errors I start receiving and if ignoreUrls allows me to ignore them or not. I'll let you know what I find.
from sentry-javascript.
Yeah - I'm already running into errors that I can't (or don't care about) fixing and that can't be excluded using ignoreUrls. Here is one such IE error I'm already receiving. The recommended fix according to Microsoft is "upgrade to IE8" And the URL is showing up as my page URL, which I obviously don't want to exclude. http://support.microsoft.com/kb/927917?wa=wsignin1.0
from sentry-javascript.
@jeremyhaile Fair enough. I'll keep it around. Thanks for letting me know!
from sentry-javascript.
No problem - appreciate the quick replies!
from sentry-javascript.
It would be nice if ignoreErrors used regexes like ignoreUrls does instead of exact match strings. In some cases, I'm running into errors that have a strange error code attached that is not always the same number. Or errors that contain the same string but have different prefixes in different browsers.
from sentry-javascript.
+1 to @jeremyhaile's suggestion - either making it use regexps or perhaps refactoring it into something like ignoreErrorPatterns
would help denoise a few bits of extension / ISP-injected noise which I see on our public site.
from sentry-javascript.
ISP-injected noise
That sounds good. π
I'm all for regexes. Do you think it makes sense to essentially merge these two options into one that just works for either urls or message names?
Or should they still be separate?
from sentry-javascript.
I think it having it be separate would be βless confusing - otherwise it
seems almost certain that someone will open an issue because their regexp
matched more than they expected.
I do like the idea of either renaming it to make it clear that what you're
providing is a regular expression or explicitly checking for string vs.
regexp to decide whether to test using ==
or .test()
to avoid surprises.
from sentry-javascript.
I agree keeping it separate - I can't think of cases where I wouldn't explicitly be writing a regex for the URL vs the message. Also - if I'm writing URL regex, it's inefficient to compare it to every message.
I also like your idea of checking if it's a string or regex before doing the comparison.
from sentry-javascript.
I'm having an issue with ignoreErrors (perhaps fixed with regex?) where I'm receiving hundreds of "" errors in Sentry. But my ignoreErrors is set to:
ignoreErrors: ['',......]
On the server it says:
9 minutes ago javascript
Any idea why this wouldn't be filtered? Let me know if I should open a separate issue for this. (and perhaps the regex issue as well)
from sentry-javascript.
@jeremyhaile Can you open up a separate issue for that?
from sentry-javascript.
Related Issues (20)
- Build fails when using nodePolyfills from rollup-plugin-polyfill-node HOT 3
- captureConsoleIntegration cannot be added as integration HOT 1
- Events not recorded HOT 4
- node-cron and node-schedule fire checkin only on app start
- TypeError when ANR is enabled in a bundled application HOT 6
- Cannot use the "latest" keyword for Sentry Lambda layer in serverless files. HOT 1
- Improve distributed tracing custom instrumentation HOT 1
- Make `@sentry/google-cloud-serverless` ESM compat
- Add runtime warning for profiling-node bindings with Node 23
- Issue with captureMessage signature change and errors from non-standard exceptions in Sentry JavaScript SDK HOT 1
- nextjs-14 (canary) Test Failed
- nextjs-14 (latest) Test Failed
- Shopify Integration Support for Errors, Performance, Session Replay HOT 2
- Add crons integration extending OpenTelementry and remove Sentry cron wrapper
- Auto instrument `JSON.parse` HOT 3
- Next.js v14.2 links don't respond to clicks when Sentry is enabled HOT 2
- Support React 19
- Automatically instrument profiling for Node and Python when Sentry is set up via the Lambda Layer HOT 5
- nextjs-app-dir (latest) Test Failed
- nextjs-app-dir (canary) Test Failed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry-javascript.