Set user agent string (sdk name + version)

[kahest]

Set user agent string (sdk name + version)

[kahest]

@supervacuus I see that this constructs opts->user_agent with name and version, but I couldn't find where this is used to set a user agent header on the transport, but I guess I looked at the wrong place - is this the relevant code?

sentry-native/src/transports/sentry_transport_curl.c

Line 105 in 2ae5de6

state->user_agent = sentry__string_clone(options->user_agent);

sentry-native/src/transports/sentry_transport_winhttp.c

Line 66 in 2ae5de6

state->user_agent = sentry__string_to_wstr(opts->user_agent);

[supervacuus]

Similarly, the minidump URL for crashpad is constructed from the DSN and the user-agent:

sentry-native/src/sentry_utils.c

Lines 362 to 374 in 2ae5de6

	sentry__dsn_get_minidump_url(const sentry_dsn_t *dsn, const char *user_agent)
	{
	if (!dsn || !dsn->is_valid || !user_agent) {
	return NULL;
	}
	sentry_stringbuilder_t sb;
	init_string_builder_for_url(&sb, dsn);
	sentry__stringbuilder_append(&sb, "/minidump/?sentry_client=");
	sentry__stringbuilder_append(&sb, user_agent);
	sentry__stringbuilder_append(&sb, "&sentry_key=");
	sentry__stringbuilder_append(&sb, dsn->public_key);
	return sentry__stringbuilder_into_string(&sb);
	}

That should also make it clearly visible when checking LB issues.

[supervacuus]

Hi @kahest

Currently, the SDK only sets the x-sentry-auth field in the transport:

This is not true. We also set the user-agent to sdk_name/version:

https://github.com/getsentry/sentry-native/blob/master/src/sentry_options.c#L322-L329

Since breakpad uses the same transport as any other envelope, this is also true with minidumps from breakpad.

With crashpad, the current solution is to append the sentry_client as part of a set of X-Sentry-Auth query parameters with the minidump request. The format is the same as with the user-agent above.

[kahest]

@supervacuus Perfect, thanks for confirming - closing this now