AWS Lambda integration not working with AWS Chalice

[getsentry]

AWS Lambda integration not working with AWS Chalice

[alonre]

FYI: I tried to bypass the exception it didn't seem to work:

    def install(self):
        if not hasattr(lambda_bootstrap, 'make_final_handler'):
            setattr(lambda_bootstrap, 'make_final_handler', None)
        old_make_final_handler = lambda_bootstrap.make_final_handler

[untitaker]

Hi, could you tell me how you create a Lambda function? Are you testing this in some kind of local emulator? I tried to reproduce this issue earlier with the Python 3.6 and 2.7 runtimes but I couldn't.

…

On Mon, Oct 8, 2018, 01:37 alonre ***@***.***> wrote: FYI: I tried to bypass the exception it didn't seem to work: def install(self): if not hasattr(lambda_bootstrap, 'make_final_handler'): setattr(lambda_bootstrap, 'make_final_handler', None) old_make_final_handler = lambda_bootstrap.make_final_handler — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAzHxVRNN4rd3zJ5ZPJdMNuIHKKgaUDxks5uipA7gaJpZM4XMF-h> .

[untitaker]

also please tell me the output of the following on AWS (without sentry-sdk installed):

import sys
import __main__
print(__main__.__file__)
print(list(
  (n, m.__file__) for n, m in sys.modules.items()
))

[untitaker]

Oh! @alonre, I'm sorry, it wasn't clear that you were getting this exception while deploying! I'll push out a fix soon, hang tight.

[untitaker]

I just release 0.3.11. If that doesn't fix the issue please give me the output of the prints above.

[hoou]

Will this work on localhost when testing? I mean, I want to run my functions, but not in AWS lambda.

[untitaker]

It will just disable the integration if it's not in AWS Lambda. What are you testing your application with?

[alonre]

Thanks @untitaker, chalice deploy now works with 0.3.11.
However, I'm not sure I'm getting exceptions sent to Sentry.

I've disabled the integration and got the printouts you requested (attached).
Thanks for looking into this!
sentry_sdk_debug_print.txt

[untitaker]

Could you enable debug=True in your call to init and get me the output? I wonder if the integration thinks it's not on AWS

[alonre]

This is what I got (tested couple of times).
Does this make sense?

[sentry] DEBUG: Shutting down HTTP transport orderly
[sentry] DEBUG: background worker got shutdown request
[sentry] DEBUG: background worker shut down
[sentry] DEBUG: Killing HTTP transport
[sentry] DEBUG: background worker got kill request
[sentry] DEBUG: Shutting down HTTP transport orderly
[sentry] DEBUG: background worker got shutdown request
[sentry] DEBUG: background worker shut down
[sentry] DEBUG: Killing HTTP transport
[sentry] DEBUG: background worker got kill request

[untitaker]

Hmm sorry, I forgot about another bug the sdk has. Could you check if this condition is true or false: https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/aws_lambda.py#L22 I would expect it to return early on your local machine but not in aws

…

On Tue, Oct 9, 2018, 22:41 alonre ***@***.***> wrote: This is what I got (tested couple of times). Does this make sense? [sentry] DEBUG: Shutting down HTTP transport orderly [sentry] DEBUG: background worker got shutdown request [sentry] DEBUG: background worker shut down [sentry] DEBUG: Killing HTTP transport [sentry] DEBUG: background worker got kill request [sentry] DEBUG: Shutting down HTTP transport orderly [sentry] DEBUG: background worker got shutdown request [sentry] DEBUG: background worker shut down [sentry] DEBUG: Killing HTTP transport [sentry] DEBUG: background worker got kill request — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAzHxfdD7qeqZUTVs6BC9M5BcyxzHVXUks5ujQn1gaJpZM4XMF-h> .

[alonre]

Running in AWS:

[DEBUG]	2018-10-09T21:00:04.298Z	__main__ hasattr('make_final_handler'): True

[untitaker]

Hmm, that sucks. So to summarize, you have a Lambda function that works normally but doesn't send events? Could you share the code?

[alonre]

1. Yes - the Lambda is working great
2. No - can't share code* (proprietary)
   (* I'll try creating a simple "chalice" App and verify I can reproduce the same behavior - and will share that code)

However, I wrote a tiny wrapper to workaround this and managed to get events:

def capture_exceptions(function):
    @functools.wraps(function)
    def wrapper(*args, **kwargs):
        try:
            return function(*args, **kwargs)
        except Exception as ex:
            sentry_sdk.capture_exception(ex)
            raise ex
    return wrapper

[untitaker]

Ah, then it's probably related to chalice. We would need a proper integration for it. I think your workaround is fine.

…

On Tue, Oct 9, 2018, 23:14 alonre ***@***.***> wrote: 1. Yes - the Lambda is working great 2. No - can't share code* (proprietary) (* I'll try creating a simple "chalice" App and verify I can reproduce the same behavior - and will share that code) However, I wrote a tiny wrapper to workaround this and managed to get events: def capture_exceptions(function): @functools.wraps(function) def wrapper(*args, **kwargs): try: return function(*args, **kwargs) except Exception as ex: sentry_sdk.capture_exception(ex) raise ex return wrapper — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAzHxTjW7GVRdEx2lvL7m4xLrxqYnxrEks5ujRGmgaJpZM4XMF-h> .

[alonre]

Ok cool.
I opened #117.
I might be able to help with the integration.
Leaving it up to you whether to close this one...

[untitaker]

Closing as remaining AWS Lambda issues should be about missing framework support