Comments (18)
Support for doctrine/dbal
v4.0 was added in 4.14.0.
from sentry-symfony.
It is being worked on.
from sentry-symfony.
We'll add support for DBAL v4; I can't give you a timeline at this point.
from sentry-symfony.
Unfortunately, since Doctrine is an optional dependency of this package, we don't require it in composer.json
besides for development purposes, hence we have no way to prevent the installation of an unsupported version. This is one of the reasons for which I strongly believe that:
- All tracing features should not be enabled by default (and this is a lost battle...)
- We should move the tracing integrations into separate packages, so that we can declare for real the dependencies they really supports in the
composer.json
from sentry-symfony.
@ste93cry What about declaring a conflict with the unsupported version, until it is supported?
from sentry-symfony.
Until resolved I solved that by going with orm 3.* but constraining dbal.
"doctrine/dbal": "3.*",
"doctrine/orm": "^3.0.0",
from sentry-symfony.
@ste93cry What about declaring a conflict with the unsupported version, until it is supported?
That would prevent users to use the whole bundle if they use DBAL 4, which is an issue only if you enable tracing.
from sentry-symfony.
See doctrine/orm
3.0.0 & doctrine/dbal
4.0.0
from sentry-symfony.
Are you using DBAL 3 or 4?
from sentry-symfony.
Are you using DBAL 3 or 4?
DBAL 4.x, it's more of a problem with doctrine/dbal
4
from sentry-symfony.
Return type switched from bool
to void
, I don't think we can make the interface cross compatible...
bindValue($param, $value, $type = Doctrine\DBAL\ParameterType::STRING): bool
bindValue(string|int $param, mixed $value, Doctrine\DBAL\ParameterType $type): void
We need to create another one, and this is probably not even the only BC that we need to handle.
from sentry-symfony.
Related to #579
from sentry-symfony.
When creating a new symfony project with --webapp, composer.json adds "doctrine/orm:^3.0" to the requires section. I wish instead it were "^2.1||^3.0", and let composer figure out which version to use based on what the dependencies support.
That would help in this case, as well as for API Platform api-platform/core#6150
from sentry-symfony.
Could anyone point out how to disable tracing ? 🙂
from sentry-symfony.
You can disable tracing as a whole using:
sentry:
tracing:
enabled: false
or you can disable tracing specifically for DBAL using:
sentry:
tracing:
dbal:
enabled: false
from sentry-symfony.
@ste93cry What about declaring a conflict with the unsupported version, until it is supported?
That would prevent users to use the whole bundle if they use DBAL 4, which is an issue only if you enable tracing.
@Jean85 Can't use the whole bundle with DBAL 4, even with tracing disabled.
from sentry-symfony.
Can't use the whole bundle with DBAL 4, even with tracing disabled.
Indeed, even with the whole bundle disabled, the application still fails with:
Fatal error: Declaration of Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingStatementForV3::bindValue($param, $value, $type = Doctrine\DBAL\ParameterType::STRING): bool must be compatible with Doctrine\DBAL\Driver\Statement::bindValue(string|int $param, mixed $value, Doctrine\DBAL\ParameterType $type): void in /app/vendor/sentry/sentry-symfony/src/Tracing/Doctrine/DBAL/TracingStatementForV3.php on line 20
from sentry-symfony.
I believe that at this point, a conflict
is the only viable solution until support for the newer version is worked on @Jean85
from sentry-symfony.
Related Issues (20)
- Support for sentry php 4.x HOT 3
- Add support for sentry/sentry v4 HOT 3
- Bump (or allow) sentry libraries to version 4 HOT 5
- Symfony SDK 5.0.0 HOT 33
- Support Symfony 7 HOT 2
- Update documentation for current versions of Symfony HOT 5
- Upgrading package from 4.12.0 to 4.13.0 HOT 1
- Add conflicting package symfony/http-client v6 HOT 7
- Upgrade to sentry/sentry:^4.0 HOT 1
- Infinite loop with mailer monolog service when running Symfony 5.4 HOT 7
- Documentation error about "ignore_exceptions" HOT 2
- Symfony 7.0 got new deprecation HOT 1
- DbalTracingPass is overridden by DoctrineBundle's own MiddlewaresPass HOT 4
- Cannot upgrade to sentry/sdk 4.0.0, since sentry/sentry-symfony 4.13.2 locked to sentry/sdk[3.6.0] HOT 1
- RequestFetcher doesn't return request
- Release reported as "1.0.0+no-version-set@{no ref" HOT 5
- Performance issue in aliases.php when not using all components that can be traced HOT 2
- Compatibility Issue with Sentry Integration: Declaration Error in Http\Message\Encoding\FilteredStream HOT 11
- PHP Fatal error: Declaration of Sentry\SentryBundle\Tracing\HttpClient\TraceableResponseForV4::getInfo(?string $type = null) must be compatible with Symfony\Contracts\HttpClient\ResponseInterface::getInfo(?string $type = null): HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry-symfony.