update_user example fails

[getstream]

update_user example fails

[bogdan-getstream]

Using symbols as hash keys is preferred in ruby, as they are immutable and not trigger GC.
But on parsing request keys are currently strings, and it's not easy to fix it as it's breaking change for the SDK users.

[ffenix113]

@peterdeme can you please also check this issue out when you will have time? Should be a quick one. Thank you.

[tbarbugli]

thanks for reporting this, in the meantime can you try client.update_user([user])?

[the-bass]

You mean like

client.update_user([{
  'id' => 'bob-1',
  'role' => 'admin',
  'name' => 'Robert Tables'
}])

?

Gives me

irb(main):004:0> client.update_user([{
irb(main):005:3*   'id' => 'bob-1',
irb(main):006:3*   'role' => 'admin',
irb(main):007:3*   'name' => 'Robert Tables'
irb(main):008:3> }])
Traceback (most recent call last):
        6: from /usr/local/bin/irb:11:in `<main>'
        5: from (irb):4
        4: from /usr/local/bundle/gems/stream-chat-ruby-1.1.0/lib/stream-chat/client.rb:101:in `update_user'
        3: from /usr/local/bundle/gems/stream-chat-ruby-1.1.0/lib/stream-chat/client.rb:94:in `update_users'
        2: from /usr/local/bundle/gems/stream-chat-ruby-1.1.0/lib/stream-chat/client.rb:94:in `each'
        1: from /usr/local/bundle/gems/stream-chat-ruby-1.1.0/lib/stream-chat/client.rb:95:in `block in update_users'
TypeError (no implicit conversion of Symbol into Integer)

[keyneston]

Just recreated this and the following works:

# update a single user
client.update_user({
  :id => 'bob-1',
  :role => 'admin',
  :name => 'Robert Tables'
})

# update multiple users
client.update_users([{
  :id => 'bob-1',
  :role => 'admin',
  :name => 'Robert Tables'
}])

Turns out the keys need to be symbols not strings. I'll update the specific example right away. I'm not sure which other examples have similar problems.

[tbarbugli]

@bogdan-d any advice here?

[keyneston]

Copying what I put in #12

I've fixed this specific issue, but there seems to be a lot of inconsistencies here.

Like this one which uses strings.

    def create_channel_type(data)
      if !data.key? "commands" || data["commands"].nil? || data["commands"].empty?
        data["commands"] = ["all"]
      end
      post("channeltypes", data: data)
    end

Easiest fix is to switch to using rails' HashWithIndifferentAccess see here. Although that requires a big import. If we want to avoid that path and just fix the code itself I can't say I'm experienced enough in ruby to know the best way (adding support for both, switching all to one way, or what).

[keyneston]

@tbarbugli can you please unassign me :D it seems I don't have permissions.

[ferhatelmas]

@keyneston 👋🏻 replaced with me 😃

[peterdeme]

#104