Giter Site home page Giter Site logo

Comments (3)

agraubert avatar agraubert commented on August 10, 2024

So right now, this actually occurs in localization, when the setup script is put together:
https://github.com/broadinstitute/canine/blob/master/canine/localization/base.py#L539

The stringify step is not responsible for quoting, it just makes sure that objects are strings, so in this case, no effect. I'm not opposed to changing the quoting so that the null override is not quoted, but default handling and other overrides still get quoted. Does that sound okay?

from canine.

agraubert avatar agraubert commented on August 10, 2024

@julianhess Actually, I'm thinking that maybe these quotes are also redundant? Like, just use shlex.quote or nothing for the null override:

https://github.com/broadinstitute/canine/blob/bdd42083cef0def94a5c53fd3be9b859a1200a07/canine/localization/base.py#L537

from canine.

agraubert avatar agraubert commented on August 10, 2024

Fixed: now the double-quoting is fixed. The null override is not necessary

from canine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.