Comments (3)
So right now, this actually occurs in localization, when the setup script is put together:
https://github.com/broadinstitute/canine/blob/master/canine/localization/base.py#L539
The stringify step is not responsible for quoting, it just makes sure that objects are strings, so in this case, no effect. I'm not opposed to changing the quoting so that the null override is not quoted, but default handling and other overrides still get quoted. Does that sound okay?
from canine.
@julianhess Actually, I'm thinking that maybe these quotes are also redundant? Like, just use shlex.quote
or nothing for the null override:
from canine.
Fixed: now the double-quoting is fixed. The null
override is not necessary
from canine.
Related Issues (20)
- Raise more informative error when no outputs are found HOT 3
- NFS creation from custom image fails silently HOT 2
- Use fallocate to enforce disk space HOT 1
- Add debug mode to `wait_for_jobs_to_finish`
- Dummy Backend hangs on linux VMs HOT 1
- orchestrator should attempt to run `delocalize.py` for jobs failed from node failures HOT 1
- Enable job shell variable expansion during delocalization
- Add job avoidance unit tests
- Reuse canine backend (docker transient) across different proceesses HOT 2
- local override HOT 5
- Dummy backend on linux permissions issues HOT 3
- Stream localization fails on preemptible NFS server
- localization.sh fails with transfer_bucket
- Copy or symlink when delocalizing a directory? HOT 1
- scancel'ing noop'd jobs is slow HOT 1
- mount error not caught HOT 2
- Wipe output directory upon job retry
- Add new condition here for localization that hit quota issue; infinite retries HOT 3
- Delete file on md5 check failure
- Add localizer for DRS URIs, and update GDC handler to use it when available HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from canine.