Giter Site home page Giter Site logo

Comments (7)

xpe avatar xpe commented on June 12, 2024

I just hand-tested my potential PR (from my fork) for my personal website; works fine. If you like this, please let me know what tests you'd like to see. I can also write some docs.

from zola.

Keats avatar Keats commented on June 12, 2024

I don't really see the point tbh, browsers can prettify it already automatically if you need.

from zola.

xpe avatar xpe commented on June 12, 2024

@Keats I can see why you might say that, but it isn't exclusively about pretty-printing. The current default, OutputStyle::Compressed, strips out comments. This makes OutputStyle::Expanded handy sometimes for debugging.

Aside: I looked at grass today. I can tell it is a lot of work to maintain feature-parity with dart-sass. I just contributed a PR over there, adding string:split which is currently missing. I mention this to motivate that having more control over grass's config options is helpful. One of my goto strategies when things go wrong is "get more visibility". Having one tools' config buried inside another can be a barrier, and it was here in this case, which I why I made the PR.

from zola.

Keats avatar Keats commented on June 12, 2024

I'm not planning to add configuration options for the sass compiler atm in any way

from zola.

xpe avatar xpe commented on June 12, 2024

I'm not planning to add configuration options for the sass compiler atm in any way

I'm a bit surprised, personally. To sum up: I provided a PR. There is a benefit to at least one user. (I doubt I'm the only one.)

Not my call to make. But if it were, the rational framing would be: benefit versus cost. Does the benefit outweigh the effort of merging the PR and maintenance? In my eyes, the cost of merging the PR is very low, expected maintenance will be very low, benefit is (admittedly) small (but not zero). For example, -0.01 + -0.02 + +.1 is still positive.

from zola.

xpe avatar xpe commented on June 12, 2024

@Keats Thanks for your work on Zola, much appreciated.

from zola.

Keats avatar Keats commented on June 12, 2024

Thanks for the kind words!

from zola.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.