Giter Site home page Giter Site logo

Comments (2)

gfscott avatar gfscott commented on June 10, 2024 1

Hm. It looks like maybe Travis doesn’t accept named capture groups in regex, so it’s failing on the ?<videoId> value.

I'll look into Travis (I haven't used it much) and consider some alternative approaches. Thanks for filing an issue!

from eleventy-plugin-youtube-embed.

gfscott avatar gfscott commented on June 10, 2024

@jmschrack So I made a PR today to try to address this. I took the liberty of forking your repo and running it through Travis, and the build passed this time:

https://travis-ci.org/github/gfscott/jmschrack.github.io/jobs/662532397

If you're able, it would be great to confirm that this update is working for you before I merge it. If you could pull that branch and give it a try yourself, I'd be obliged. 🙏

As I suspected, the problem is the named capture groups, which were only added to Node with version 10. Since your build is set to use Node 8, those RegExes wouldn't work. Seems better to just use a more widely supported method, rather than requiring Node 10.

from eleventy-plugin-youtube-embed.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.