Giter Site home page Giter Site logo

The ComPtr API is unsound. about wgpu HOT 5 OPEN

Brezak avatar Brezak commented on June 25, 2024 1
The ComPtr API is unsound.

from wgpu.

Comments (5)

ErichDonGubler avatar ErichDonGubler commented on June 25, 2024 6

Speaking for myself and @cwfitzgerald (with whom I've spoken about this directly), I think we have no attachment to the d3d12 crate; we'd also rather migrate directly to the windows ecosystem, rather than fix d3d12.

from wgpu.

teoxoy avatar teoxoy commented on June 25, 2024 2

It looks like we do have debug asserts for this but I agree our implementation is not great. Rather than rewriting it, I think we should just move over to windows-rs or a subset of it (see #3207).

from wgpu.

onkoe avatar onkoe commented on June 25, 2024

it's probably not scarier than trusting in libloading, but the bindings for d3d12 are automatically generated and kinda verbose.

keep msdn handy if you tackle this issue! https://github.com/microsoft/windows-rs/tree/master/crates/libs/windows/src/Windows/Win32/Graphics/Direct3D12

from wgpu.

MarijnS95 avatar MarijnS95 commented on June 25, 2024

@onkoe per #3207 (comment) the migration to the windows crate ecosystem is already being worked on 🙂

from wgpu.

onkoe avatar onkoe commented on June 25, 2024

sounds great! just wanted to warn anyone who expected a drop-in replacement

that said, your branch looks very nice already. can see why you'd start immediately! 😄

from wgpu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.