Null => Nill value

[HMAZonderland]

Null => Nill value

[HMAZonderland]

My bad, I guess overlooked something. I had to set PhpXmlRpc::$xmlrpc_null_extension = true

[gggeek]

yup :-)

[gggeek]

Side note: any feedback on the php53 branch? Things you'd like to see added or changed?

[HMAZonderland]

Well I have to say using this branch feels better. I do have to change ALOT of code to be compatible with this, but its for a better cause.

I did find something weird tho. It seems as if the php53 branch RPC => function map is much stricter. I have to add that I did write a class on top of the Server class to parse a token I send with each call.

This used to work (please note, there is a double entry in the signature. I just discovered this as a bug)

'Article.ArticleCount' => array(
    'class' => 'Wiq_ArticleController',
    'function' => 'Article_ArticleCount',
    'signature' => array(
        array($xmlrpcArray, $xmlrpcString, $xmlrpcInt, $xmlrpcInt),
        array($xmlrpcArray, $xmlrpcString, $xmlrpcNull, $xmlrpcNull),
        array($xmlrpcArray, $xmlrpcString, $xmlrpcNull, $xmlrpcInt),
        array($xmlrpcArray, $xmlrpcString, $xmlrpcNull, $xmlrpcInt)
    ),
    'docstring' => '[token] [active] [public]',
    'cache' => true
),

Updating to this (please note, bug still there):

'Article.ArticleCount' => array(
    'class' => 'Wiq_ArticleController',
    'function' => 'Article_ArticleCount',
    'signature' => array(
        array(Value::$xmlrpcArray, Value::$xmlrpcString, Value::$xmlrpcInt, Value::$xmlrpcInt),
        array(Value::$xmlrpcArray, Value::$xmlrpcString, Value::$xmlrpcNull, Value::$xmlrpcNull),
        array(Value::$xmlrpcArray, Value::$xmlrpcString, Value::$xmlrpcNull, Value::$xmlrpcInt),
        array(Value::$xmlrpcArray, Value::$xmlrpcString, Value::$xmlrpcNull, Value::$xmlrpcInt)
    ),
    'docstring' => '[token] [active] [public]',
    'cache' => true
),

Now the Server responded with Incorrect signature when sending: Article.ArticleCount('token', 1, null)

ps: I did correct the bug by now. ;-)

[gggeek]

Interesting use case - I do not think there's any scenario in the test suite which uses xmlrpc null values.
I will try to look over it in the weekend (no promise given though).
Otoh: what about not sending a value at all when it is NULL?
eg:
'signature' => array( array(Value::$xmlrpcArray, Value::$xmlrpcString, Value::$xmlrpcInt), array(Value::$xmlrpcArray, Value::$xmlrpcString, Value::$xmlrpcInt, Value::$xmlrpcInt), array(Value::$xmlrpcArray, Value::$xmlrpcString, Value::$xmlrpcNull, Value::$xmlrpcInt), ),

pps: if you don't wanna go over changing your code, there's still the compatibility layer available...

[HMAZonderland]

I wanted to update the code, its time to do some refactoring etc. And it helps to find old bugs.

I do need the null value. For instance counting articles that are public(1) or not-public(0) or where this status does not matter, null