Giter Site home page Giter Site logo

Comments (9)

jbrooksuk avatar jbrooksuk commented on September 13, 2024

The markers aren't handled very well.. This could be fixed with periodic gutter cleaning or better handling of markers.

from guttercolor.

tdhsmith avatar tdhsmith commented on September 13, 2024

Maybe a good temporary measure would be to provide a command that flushed the markers?

from guttercolor.

jbrooksuk avatar jbrooksuk commented on September 13, 2024

Sounds like a plan.

from guttercolor.

jbrooksuk avatar jbrooksuk commented on September 13, 2024

This could be implemented as part of #44 - the reason for this is that the same command which will clear the gutter on plugin_unloaded could be used as a Palette Command manually.

Currently each marker has a name of gutter_color_%s where %s is the region.a (the first end of the region) value. I don't know if it's possible to iterate all of the regions beginning with gutter_color and then remove them - that's what I'm looking into now.

from guttercolor.

redfellow avatar redfellow commented on September 13, 2024

Perhaps you could take a look how the VCS Gutter plugin handles this? It's
never caused me any issues with wrong things in the gutter.

from guttercolor.

jbrooksuk avatar jbrooksuk commented on September 13, 2024

I looked at the TrailingSpaces plugin and that solely uses TrailingSpacesMatchedRegion. So I changed GC to do the same but with GutterColorRegion and there didn't seem to be any adverse effects. More testing needs to be done and then I'll be able to get the command in to clear the regions up.

from guttercolor.

tdhsmith avatar tdhsmith commented on September 13, 2024

Oh so we could potentially have many regions using the same region key? That would make removing them much, much easier. 👍

I was playing with brute-force search and that was way too slow.

from guttercolor.

jbrooksuk avatar jbrooksuk commented on September 13, 2024

Yeah, exactly. I was thinking of brute-force myself then remembered that TrailingSpaces only uses one key.

Once the other bits are merged in, I'll swap the region keys to just one constant value, see how it works with the recent changes.

from guttercolor.

gordio avatar gordio commented on September 13, 2024

Wrong lines parsed as with color:
2014-11-25 13-27-13 design css gordio site

from guttercolor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.