Some improvements

[ggozad]

Some improvements

[ggozad]

Very happy behaving is seeing more use!
Since you've done work on this already, I would suggest separate pull requests (with tests please when necessary) would land them in asap.

1. Makes sense. Please make a PR with perona_vars for appropriate steps. I've just added them where I found it useful.
2. The switch happens within scenarios. But we reset the personas before each scenarios. So while in a scenario you can reuses the browser. Isn't this the expected behaviour?
3. I also find xpath more expressive (and easier). But I would be happy to have both. One way would be to try first xpath and then css within the steps but that would make the steps slower. Perhaps differentiate in the steps definitions?

Anyway, more than happy to move forward with all these, can we have separate pull requests and issues so that we can track what's going on?

[rosselliott]

Cool, I'll put some changes together and issue a pull request. For the
switching personas issue it really does start a new connection, but the fix
is so simple, I'll put that in a PR as well. I must say that we are all
impressed with behaving, even, and I'm a developer not a tester. It's nice
to give something back so I'm pleased to be able to add my changes, we have
a few steps that do interesting and useful things, I'll include some of the
more general ones in a PR as well.

Ross
On 14 Jun 2014 08:38, "Yiorgis Gozadinos" [email protected] wrote:

Very happy behaving is seeing more use!
Since you've done work on this already, I would suggest separate pull
requests (with tests please when necessary) would land them in asap.

1. Makes sense. Please make a PR with perona_vars for appropriate steps.
   I've just added them where I found it useful.
2. The switch happens within scenarios. But we reset the personas
   before each scenarios. So while in a scenario you can reuses the browser.
   Isn't this the expected behaviour?
3. I also find xpath more expressive (and easier). But I would be happy to
   have both. One way would be to try first xpath and then css within the
   steps but that would make the steps slower. Perhaps differentiate in the
   steps definitions?

Anyway, more than happy to move forward with all these, can we have
separate pull requests and issues so that we can track what's going on?

—
Reply to this email directly or view it on GitHub
#15 (comment).

[ggozad]

Awesome! Don't hesitate breaking things into several PRs, it makes it easier to discuss and review. Thank you and looking forward to your contribution!