Comments (5)
Side note: the GdlCleaner transformation should fix both of these (along with a few other common problems), but this is certainly something we could add to validation. It would be easy enough to check.
from ggp-base.
Awesome, thanks! What I'd ultimately like is to have any game that passes validation be good enough to publish (permanently!) on a public game repository with no manual review. We're not there yet, but that's my ultimate goal.
from ggp-base.
I have this implemented, but a lot of the test case games violate this, and it's not clear whether they're meant to test cases of games written like this or not (e.g. in test case 1a). Which is to say, do I "fix" those game descriptions, or update the StaticValidatorTest to say they're supposed to fail?
from ggp-base.
Is the malformed GDL essential to what's being tested? If so, indicate that those test cases shouldn't pass the StaticValidator since they're deliberately malformed. Otherwise, if the malformed rules could be rewritten in a way that they validate properly, but still test what they need to test, they should be rewritten.
I definitely think we should have test cases that include malformed rules, to make sure our players can handle them; but that doesn't mean that all (or most) of the test cases have to include malformed GDL, since many test cases will be testing things unrelated to malformed GDL.
from ggp-base.
See #30
from ggp-base.
Related Issues (20)
- Error Loading Project: Cannot load facet Scala (ggp-base-master) HOT 2
- Fix HumanNewMovesEvent constructor HOT 1
- "and" operator not a recognized literal in GdlFactory.createLiteral(Symbol symbol) HOT 1
- Better support for testing visualizations in browsers
- Move to Java 8 HOT 1
- Add option to select all gamers in kiosk HOT 3
- Question: Where can I find more GGP domains (kif files) ? HOT 2
- DeORer does not correctly handle `not` literals HOT 1
- OPNF bug in test case 5d
- Javadoc has errors HOT 2
- Automatic detection of player connection HOT 3
- Bad JVM arg in build.xml/build.gradle HOT 3
- Make StaticValidator use Griddle validation library HOT 1
- A GGP game HOT 1
- Add ability to abandon running games in the Server app HOT 3
- Expose game versioning in GameRepository HOT 2
- Add explicit versioning and publish versioned .jars HOT 12
- ClassCastException when constructing Gdl programmatically HOT 5
- HTML parsing library for visualizations messes up divs HOT 4
- Server app: Case-insensitivity can pollute XML output to subsequent games
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ggp-base.