Giter Site home page Giter Site logo

Comments (13)

codyps avatar codyps commented on May 22, 2024

I should also note that as a temporary work around I've just adjusted the code to skip patterns starting with '/' so I don't miss important things.

from the_silver_searcher.

mutewinter avatar mutewinter commented on May 22, 2024

Would love to see this get added. Right now patterns like /log/* are not being used for Ag's ignore. I'm running HEAD.

from the_silver_searcher.

losingkeys avatar losingkeys commented on May 22, 2024

Same here (though I'm running version 0.14). The pattern that isn't getting ignored for me is /log/*.log (for reference).

from the_silver_searcher.

raimo avatar raimo commented on May 22, 2024

Just ran into this problem also. Using patterns that begin with '/' is the best practice in large projects if the exact directory structure is known, so this really is a crucial feature.

My specific problem is having this in .gitignore:

/tmp/performance

Running ag blabla still returns matches from file tmp/performance/PERF-REPORT-234234234.html

from the_silver_searcher.

MSch avatar MSch commented on May 22, 2024

Just ran into this problem too. At first I thought that ag doesn't deal with gitignores in subfolders. Having support for this is IMO crucial, because look at for example the default gitignore of Rails projects:

# Ignore bundler config.
/.bundle

# Ignore the default SQLite database.
/db/*.sqlite3
/db/*.sqlite3-journal

# Ignore all logfiles and tempfiles.
/log/*.log
/tmp

from the_silver_searcher.

smathy avatar smathy commented on May 22, 2024

Umm, 4148d6a seems to have reversed the proper handling of the leading / in .gitignore. Reverting that commit makes ag do the right thing for me.

from the_silver_searcher.

ggreer avatar ggreer commented on May 22, 2024

Actually, reverting that commit will make ag treat slashes incorrectly. Instead of just ignoring /tmp, it will ignore all files and directories named tmp.

It's safer to show extra matches than to silently ignore a file that the user expects to be searched.

from the_silver_searcher.

smathy avatar smathy commented on May 22, 2024

Ahh, I see. So we really need something that prepends a . for leading /s

from the_silver_searcher.

bitboxer avatar bitboxer commented on May 22, 2024

I would love to see this fixed 😸

from the_silver_searcher.

rik avatar rik commented on May 22, 2024

This seems to be closed with #355

from the_silver_searcher.

ggreer avatar ggreer commented on May 22, 2024

That is correct.

from the_silver_searcher.

bitboxer avatar bitboxer commented on May 22, 2024

👍 Thanks for fixing this! ❤️

from the_silver_searcher.

smathy avatar smathy commented on May 22, 2024

Thanks 👌

from the_silver_searcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.