Not respecting .gitignore?

[ggreer]

Not respecting .gitignore?

[ggreer]

Thanks for submitting this bug report, but can you give me more info? It'd be handy to see:

• The line in your .gitignore that ignores the log files.
• The paths to the .gitignore file and log file.
• The parameters you're passing to ag and the directory you're running it in.

Without this information, it's really hard for me to reproduce the bug. If I can't reproduce it, I can't fix it.

[rstacruz]

In the report above, the ignore line is /logs/*.log. The command was ag hello. It was ran on the git repo. It's easily-reproduceable too:

[rstacruz]

I deleted my long paste comment and put it in a gist here. I hope this helps. https://gist.github.com/ef4af99306276aa31637

[ggreer]

Thanks for giving me a failure case.

echo "/logs/*.log" > .gitignore

I'm just running fnmatch on the lines, so specifying a path doesn't work. I knew git allowed paths but totally spaced on adding support for it.

Fixing this will probably take me a little while. Be patient.

[rstacruz]

These gitignore lines don't work with ag either:

/logs
/logs/
logs/*
/logs/file.log
logs/file.log

These work:

logs
file.log

...all of these will ignore the file in question in Git.

[ggreer]

Just FYI, I haven't forgotten about this issue. Fixing it requires quite a few changes, since scandir() doesn't pass the current path to the filter function that it calls on each directory entry. I might start off with a half-assed fix that uses a global, but I'd prefer to make this easier to parallelize. The right solution is to write my own scandir().

But replacing scandir with my own equivalent might cause some problems.

[cabello]

I was having this issue, I sent you a pull request trying to help you to close it.

Same problem here.

[ggreer]

Ok, this should be fixed now.

[jmuheim]

Thank you!