Giter Site home page Giter Site logo

symlink option in config about tvrenamr HOT 4 CLOSED

ata2001 avatar ata2001 commented on July 23, 2024
symlink option in config

from tvrenamr.

Comments (4)

ghickman avatar ghickman commented on July 23, 2024

@ata2001 – That's exactly how I would expect it to be passed down from the config. If you make a PR with your changes I'd be happy to merge it.

Thanks again for all your work on the symlink feature!

from tvrenamr.

ata2001 avatar ata2001 commented on July 23, 2024

Hi!

I tried to test this, then found out, the other boolean config options are neither functional (don't work I mean).

The problem is:
If the option is boolean, click returns either True or False (that's why we call it boolean), so that will override command line, even if False. We could solve it by setting default to None, while is_flag is still true, like:
@click.option('-t', '--the', is_flag=True, default=None, help="Set the position of 'The' in a show's name to the end of the show name")

from tvrenamr.

ata2001 avatar ata2001 commented on July 23, 2024

Created PR.

#88

from tvrenamr.

ata2001 avatar ata2001 commented on July 23, 2024

Solved by #88.

from tvrenamr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.