Giter Site home page Giter Site logo

Comments (11)

Phil-Friderici avatar Phil-Friderici commented on September 2, 2024

+1 having seen the same issue here. Hope I can find time soon to create & propose a fix.

from puppet-module-ssh.

Phil-Friderici avatar Phil-Friderici commented on September 2, 2024

v3.43.0 is the last version that does not break on Solaris.

from puppet-module-ssh.

Phil-Friderici avatar Phil-Friderici commented on September 2, 2024

Thanks to @nalyanyam I got a list of Solaris incompatible parameters:

KerberosOrLocalPasswd - not valid
KerberosTicketCleanup - not valid
KerberosGetAFSToken - not valid
TCPKeepAlive - not valid
ShowPatchLevel - not valid
MaxSessions - not valid
PermitTunnel - not valid

We should find a way to exclude them from Solaris SSHd for the future.
Two way come into my mind here:

  • Solaris specific template without the incompatible parameters
  • enable the template to print out lines only if the value is not undef and set OS default accordingly

I would prefer last one as it could help in other situattions too.
@ghoneycutt What do you think ?

from puppet-module-ssh.

ghoneycutt avatar ghoneycutt commented on September 2, 2024

I'd like to keep one template and configure it so that if a setting is undef it will not show up.

from puppet-module-ssh.

ghoneycutt avatar ghoneycutt commented on September 2, 2024

Perhaps we could tap into E's Jenkins service and get a few Solaris VM's. We could build a job that runs the code from a PR and tests it on a Solaris VM with serverspec and then reverts the VM. This would give us an automated way to ensure Solaris is good.

from puppet-module-ssh.

Phil-Friderici avatar Phil-Friderici commented on September 2, 2024

@ghoneycutt Having some Jenkins magic to verify compatibility would be awesome. Getting an environment for full automated testing is on my wish list. Just I believe this will take some time before I can start working into that direction.

from puppet-module-ssh.

Phil-Friderici avatar Phil-Friderici commented on September 2, 2024

But I will start working on an suggestion for the template.

One detail come into my mind; in Hiera it is not possible to override a value to become undef once it is set. Therefore I think it would be good to have an alternative 'stop word' beside undef.

from puppet-module-ssh.

nalyanyam avatar nalyanyam commented on September 2, 2024

@Phil-Friderici These settings in ssh_config are also not valid on Solaris

AddressFamily
Tunnel
TunnelDevice
PermitLocalCommand
HashKnownHosts

from puppet-module-ssh.

Phil-Friderici avatar Phil-Friderici commented on September 2, 2024

There is my suggestion how to fix the incompatible parameters on Solaris: #213

@ghoneycutt if this goes into the right direction, I'll add the same for the other parameters.

from puppet-module-ssh.

Phil-Friderici avatar Phil-Friderici commented on September 2, 2024

Hiera does not allow reseting a specified value back to undef again. As workaround I have added the value 'unset' which does that.

@nalyanyam To address the Solaris incompatible parameters I have take care that each changeable parameter can take 'unset' as value. This will not add the parameter to the configuration files anymore.

I was only able to do that for the already parameterized parameters. Don't know how to progress with the other incompatible parameters. Please see/test the code from the PR #213.

ssh_config
AddressFamily
Tunnel
TunnelDevice
PermitLocalCommand

sshd_config
KerberosOrLocalPasswd
KerberosTicketCleanup
KerberosGetAFSToken
ShowPatchLevel

from puppet-module-ssh.

ghoneycutt avatar ghoneycutt commented on September 2, 2024

Thanks everyone! Released in v3.49.1

from puppet-module-ssh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.