Comments (24)
@AurelienLourot Contributing guidelines should also be included.
Right now what shows up is how to run the project locally which shall be kept under a separate title.
cheers π
from ghuser.io.
@AurelienLourot Hey π
Just started using ghuser for my github account and noticed thatβs it's not responsive on mobile devices like my galaxy note 8. Would love to work a bit on the UI to make it work on mobile devices :)
from ghuser.io.
@AurelienLourot I would love to work on this issue π
from ghuser.io.
oh yes please :) that would be great, thanks!
from ghuser.io.
@AurelienLourot You may assign this issue to me. Right now no one is assigned π
from ghuser.io.
Yes I wanted to, but I can only assign issues to collaborators. Collaborators have push rights on all branches, so it's a bit early for me to give you so many access rights π That's why I have created the assigned
label, so at least it's obvious for other people and no one will steal this task from you π
from ghuser.io.
I can only assign issues to collaborators
it's not 100% true by the way, I can also assign issues to their original authors. For example #72 I'll be able to assign it back to you when I'm done with it, but unfortunately not this one #46. Not sure why GitHub made this choice.
from ghuser.io.
Fine π
from ghuser.io.
The project hierarchy seems a bit confusing to me since I haven't looked into reframe.js
before.
It would be great if you could mention those source files which makes sense to my task.
I came across multiple stylesheets.
Thank you π
from ghuser.io.
You're right, I need to write things inside reframe/README.md
, it's too empty, I'll try to do this tomorrow.
What you'll have to touch is inside reframe/views/profile/
. The main React component is Profile.js
. Each *.js
file there starting with a capital letter is a React component. Some components come together with a stylesheet.
The CSS itself is quite messy, because I have manually copied the GItHub CSS that I needed, which was already messy. Feel free to improve things there :) Thanks!
from ghuser.io.
By the way, you can chat with me and @brillout (Reframe's author and big contributor of ghuser) on Reframe's Discord chat.
I need to go offline for a few hours but in general I'm all the time there :)
from ghuser.io.
Hi @jamesgeorge007 :) Still working on this?
from ghuser.io.
@AurelienLourot Sorry for the delay. I started out examining the project hierarchy and in between got busy with one of the projects that I'm engaged with.
I'll come up with the required workarounds ASAP π
Just curious to know that whether you stopped following me for the same reason π .
from ghuser.io.
no problem, no pressure :)
unfollowing is not related: I receive an e-mail when someone I follow stars or creates a repo, and I look into these repos to discover things that might be useful to me in a foreseeable future. For example if someone is starring a lot of Go libs right now, I unfollow as it's not relevant for me right now and I might refollow that person some day :) So there is nothing personal here, and usually the amount or persons I follow stays around 30.
from ghuser.io.
@AurelienLourot for the NavBar part is it Ok to bring about react-bootstrap (The bootstrap-3 binding for React) which takes care of the responsiveness part by bringing in hamburger button for smaller screens.
from ghuser.io.
yes if that's easier π we should then get rid of bootstrap-4 that we use already, because mixing up might be nasty
from ghuser.io.
@AurelienLourot if that's the case I would use reactstrap instead. Well, what do you prefer?
from ghuser.io.
Personally I think it's nicer to be on bootstrap 4 than 3, and at the moment all components of bootstrap we use need only bootstrap.min.css
(no JS at all), and bootstrap's navbar is as well purely CSS. So I'm not sure it has any advantage to change everything to react-bootstrap, or am I missing something?
And BTW we're already using a bootstrap navbar and also bootstrap for several components. I'm just blocking the responsiveness with a min-width
in PageContent.css
.
from ghuser.io.
Fine π
from ghuser.io.
@AurelienLourot I made some sort of minor workarounds for larger screens @ #123
For mobile screens it requires an overall redesign of the UI part and I would love to hear your suggestions on the same. Does it suit your requirement?
Do you have some sort of wire-frame on how it should appear on the mobile devices?
from ghuser.io.
@AurelienLourot It would be great if you could invite me to the ghuser organisation π
from ghuser.io.
@jamesgeorge007 Thanks a lot for your contribution again!
Adding you to the organization would give you some permissions and I feel it's too early. Maybe I'm too wary but one pull request is not enough for me to trust you and give you these permissions. If you start doing regular/major contributions, then I'll definitely think about it!
from ghuser.io.
@AurelienLourot Fine, just enquired π
from ghuser.io.
Thanks @venarius and @jamesgeorge007 !
from ghuser.io.
Related Issues (20)
- Wrong total of stars HOT 1
- Slow on firefox HOT 4
- Enhance my profile HOT 1
- Cannot read property 'repos' of null HOT 1
- ghuser profile is not Updating on updating github profile HOT 1
- github-contribs is broken HOT 3
- "Contributed to" org links are broken HOT 2
- Feature Request: Leaderboard / Ranking
- Create GHuser profile HOT 1
- Expand arrow doesn't expand HOT 1
- Does not work on Microsoft Edge HOT 3
- Count committers and authors differently? // formerly: Phantom commits created when editing on GitHub.com HOT 8
- Link and integration into https://starhub.be HOT 1
- username update issue HOT 2
- Mobile View Logo
- Archived Repos?
- Freezing / unmaintaining ghuser.io HOT 5
- Allow links to keybase profiles from ghuser profiles HOT 2
- Contribution Frequency and Contribution Status
- I would like to have my ghusher profile
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghuser.io.