Auto save on tab removal

[sanjeevApple]

Auto save on tab removal

[gildas-lormeau]

What changes did you apply in SingleFile (related to this issue)?

[sanjeevApple]

Sorry for the delay. I made changes in src/ui/bg/ui-menus.js to turn on MENU_ID_AUTO_SAVE_TAB to true. I also made changes in src/core/bg/config.js to enable autoSaveUnload: true. I think the issue was may be rebuilding the chromium zip file, because I was making the changes in the exploded directory directly and loading the extension through puppeteer. But these changes were being picked from lib, so rebuilding solved the issue.

Now it has been working really well, which helped solve the problem of saving long and content rich pages through singlefile cli. But from time to time, autosave on page unload does not save the file.

Here are the steps:

1. Auto save this tab is the default in my set up and auto save on unload is true.
2. I load the extension through puppeteer, go to the page www.apple.com/apple-vision-pro, simulate scroll to the bottom, and then call goBack to basically unload the page. This normally works for most pages, but from time to time fails for apple vision pro.
3. You can easily simulate this in normal set up. Open chrome, get the singlefile extension, turn autosave on unload, open a tab, and turn on auto save this tab, and load the Url. Press on back arrow, and no file is saved. Use another Url like www.apple.com or www.apple.com/watch, everything works fine.

I think for some reason the save message is not coming through for some pages, in case they are heavy in content. I tried giving it time before I go back in that tab or before I close the browser, but it just does not produce a file.

[gildas-lormeau]

Thank you for the feedback. I'm glad to hear that you were able to find the cause the problem. I tried to reproduce the bug as described in the step 3 but I cannot reproduce it. Every time I do the test with www.apple.com/apple-vision-pro, the page is downloaded as expected after pressing the back button. Do you have other extensions installed?