Reproducibility -- include datasets from paper in repo

[giotto-ai]

Reproducibility -- include datasets from paper in repo

[MonkeyBreaker]

I think it is a good idea, but I would not put it directly in main branch.
Maybe we could create a benchmark branch and put there all the data-sets we want, what do you think ?
The reason is that I think the data should not be directly present in the package or at least in the main branch of the package.

[ulupo]

I think it is a good idea, but I would not put it directly in main branch.

Hmm, I'm not sure I agree. Though I think I see why you say this ("only code in main"), including benchmarks scripts and data is the approach in scikit-learn for example: https://github.com/scikit-learn/scikit-learn (see benchmarks folder with scripts, and the datasets subpackage with the data itself). Additionally, the data would be saved as text files, not as binary.

[MonkeyBreaker]

I was not aware of scikit-learn practices, and because we try to follow them on giotto-tda, we should also follow them here.

Though I think I see why you say this ("only code in main")

Exactly, but it is more a matter of taste (mine in this case) 😛