Giter Site home page Giter Site logo

Comments (7)

physikerwelt avatar physikerwelt commented on May 26, 2024

@AndreG-P did you already solve this problem. I vaguely remember that you had a similar issue?

from mathmltools.

AndreG-P avatar AndreG-P commented on May 26, 2024

Actually, you did... It was a bug in vmext: gipplab/vmext#23

from mathmltools.

physikerwelt avatar physikerwelt commented on May 26, 2024

@vstange can you follow the approach from https://github.com/ag-gipp/vmext/pull/25/files#diff-c9cf159d96357b7583ac5bc9f33564adR45

from mathmltools.

vstange avatar vstange commented on May 26, 2024

Noted.

from mathmltools.

physikerwelt avatar physikerwelt commented on May 26, 2024

can this ticket be closed @vstange ?

from mathmltools.

AndreG-P avatar AndreG-P commented on May 26, 2024

@physikerwelt I'm not sure what the problem is. The code already inspects nodes more closely based on
https://github.com/ag-gipp/MathMLTools/blob/00c269d0c313b317a5b5333434b6983157461a11/mathml-converters/src/main/java/com/formulasearchengine/mathmltools/converters/MathMLConverter.java#L232-L245

For vmext you implemented:

    const content = this.select('//m:annotation-xml[@encoding="MathML-Content"]', this.doc, true);
    if (!content) {
      throw new Error("No content MathML present");
    }
    return this.parseApply(content.firstChild);

As you can see, the method above already checks the same information. So either you can tell me what is broken or give me an example that does not work.

from mathmltools.

physikerwelt avatar physikerwelt commented on May 26, 2024

It is probably an old issue that had been resolved before

from mathmltools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.