Giter Site home page Giter Site logo

Comments (9)

McFoggy avatar McFoggy commented on July 30, 2024

@diogosantana I have introduced checks but unfortunately my local SMTP does not fail when using invalid user/emails adress ; so I am not sure it will solve the issue as expected.
Could you please confirm that the modifications fix your problems in your case.
I have prepared gitbucket-announce-plugin-1.3-alpha1 alpha release for tests : stop gitbucket, download the new jar, replace gitbucket-announce-plugin.jar in your GITBUCKET\plugins directory with this new one, and relaunch.
Thanks for your feedback.

from gitbucket-announce-plugin.

diogosantana avatar diogosantana commented on July 30, 2024

Sure. I'll test it and feed back the result here.
Em 25/02/2016 05:31, "Matthieu Brouillard" [email protected]
escreveu:

@diogosantana https://github.com/diogosantana I have introduced checks
but unfortunately my local SMTP does not fail when using invalid
user/emails adress ; so I am not sure it will solve the issue as expected.
Could you please confirm that the modifications fix your problems in your
case.
I have prepared gitbucket-announce-plugin-1.3-alpha1
https://github.com/McFoggy/gitbucket-announce-plugin/releases/tag/1.3-alpha1
alpha release for tests : stop gitbucket, download the new jar, replace
gitbucket-announce-plugin.jar in your GITBUCKET\plugins directory with
this new one, and relaunch.
Thanks for your feedback.


Reply to this email directly or view it on GitHub
#10 (comment)
.

from gitbucket-announce-plugin.

diogosantana avatar diogosantana commented on July 30, 2024

@McFoggy I do realize that my installation were using Java 7, so I got class version error. I changed to Java 8, but I was still using GitBucket 3.10 (Java 7 compiled) and got the same problem.

Now I will migrate the environment to Java 8 and GitBucket 3.11, but it will take a while because of work requirements. I'll let you know.

from gitbucket-announce-plugin.

McFoggy avatar McFoggy commented on July 30, 2024

@diogosantana any news? could you try with your SMTP server?

from gitbucket-announce-plugin.

diogosantana avatar diogosantana commented on July 30, 2024

Not yet. My ops team will upgrade the server environment to match GitBucket requeriments, but it will take some days. My expectation is later this week.

from gitbucket-announce-plugin.

diogosantana avatar diogosantana commented on July 30, 2024

@McFoggy It worked, the e-mail message were sent to all valid address and a error message was registered to the log. But item 3 is stil occuring.

gitbucket-announce-plugin-issue10

from gitbucket-announce-plugin.

McFoggy avatar McFoggy commented on July 30, 2024

@diogosantana I have adapted the code and published a temporary version on my fork

Using gmail smtp I do not receive any failure when using non existing emails, so again I need you to test. Thanks for your support and feedback.

from gitbucket-announce-plugin.

diogosantana avatar diogosantana commented on July 30, 2024

It worked. But when I simulate another kind of Exception (authetication failed) the page show "Announce has been sent.".

I do contribute a PR to your fork, please have a look. With those changes all went well.

from gitbucket-announce-plugin.

diogosantana avatar diogosantana commented on July 30, 2024

The PR: McFoggy#1

from gitbucket-announce-plugin.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.