Unable to lock and unlock specific environments

[github]

Unable to lock and unlock specific environments

[GrantBirki]

While testing out this bug, I think I found another with the .lock command 😱.

.lock <environment> --reason <text> does actually claim a lock but it does a .wcid (where can I deploy) or .lock --info style command instead. This is certainly a bug.

[GrantBirki]

My bug was a rather silly one, and one that was really rare to begin with and I just happened to run into it. My bug is now resolved but I still need to test out the logic that you are doing here to see what is happening. In my PR (linked above), I did add a whole bunch of additional "lock" related debug logging. Please upgrade to the following version and re-run your command with debug logs enabled and I'll take a look! 👀

v7.2.2

[bzurkowski]

@GrantBirki The locking feature worked for me after upgrading to v7.2.2:

Below are the logs that you requested.

Lock

Run github/[email protected]
##[debug]comment body does not start with trigger: ".deploy app"
##[debug]comment body does not start with trigger: ".plan app"
✅ comment body starts with trigger: ".lock app"
##[debug]comment body does not start with trigger: ".unlock app"
##[debug]comment body does not start with trigger: ".help app"
##[debug]comment body does not start with trigger: ".wcid"
##[debug]Found environment target for lock request: app-dev
##[debug]lock() called with ref: test-issueops
##[debug]lock() called with sticky: true
##[debug]lock() called with environment: null
##[debug]lock() called with detailsOnly: false
##[debug]lock() called with postDeployStep: false
##[debug]detected lock env: app-dev
##[debug]detected lock global: false
##[debug]constructed lock branch name: app-dev-branch-deploy-lock
##[debug]checking if lock file exists on branch: global-branch-deploy-lock
lock file does not exist on branch: global-branch-deploy-lock
##[debug]checking if branch app-dev-branch-deploy-lock exists...
##[debug]lock branch app-dev-branch-deploy-lock does not exist
##[debug]attempting to create lock branch: app-dev-branch-deploy-lock...
Created lock branch: app-dev-branch-deploy-lock
##[debug]attempting to create lock...
global lock: false
deployment lock obtained
deployment lock is sticky
##[debug]Node Action run completed with exit code 0
##[debug]Save intra-action state isPost = true
##[debug]Save intra-action state actionsToken = xxx
##[debug]Save intra-action state comment_id = xxx
##[debug]Save intra-action state reaction_id = xxx
##[debug]Save intra-action state bypass = true
##[debug]Set output comment_body = .lock app app-dev
##[debug]Set output comment_body = .lock app app-dev
##[debug]Set output comment_body = .lock app app-dev
##[debug]Set output comment_body = .lock app app-dev
##[debug]Set output comment_body = .lock app app-dev
##[debug]Set output comment_body = .lock app app-dev
##[debug]Set output type = lock
##[debug]Set output triggered = true
##[debug]Set output comment_id = xxx
##[debug]Set output initial_reaction_id = xxx
##[debug]Set output actor_handle = bzurkowski
##[debug]Set output actor = bzurkowski
##[debug]Finishing: Gate branch deployment

Unlock

Run github/[email protected]
##[debug]comment body does not start with trigger: ".deploy app"
##[debug]comment body does not start with trigger: ".plan app"
##[debug]comment body does not start with trigger: ".lock app"
✅ comment body starts with trigger: ".unlock app"
##[debug]comment body does not start with trigger: ".help app"
##[debug]comment body does not start with trigger: ".wcid"
##[debug]Found environment target for unlock request: app-dev
successfully removed lock
##[debug]Node Action run completed with exit code 0
##[debug]Save intra-action state isPost = true
##[debug]Save intra-action state actionsToken = ***
##[debug]Save intra-action state comment_id = xxx
##[debug]Save intra-action state reaction_id = xxx
##[debug]Save intra-action state bypass = true
##[debug]Set output comment_body = .unlock app app-dev
##[debug]Set output comment_body = .unlock app app-dev
##[debug]Set output comment_body = .unlock app app-dev
##[debug]Set output comment_body = .unlock app app-dev
##[debug]Set output comment_body = .unlock app app-dev
##[debug]Set output comment_body = .unlock app app-dev
##[debug]Set output type = unlock
##[debug]Set output triggered = true
##[debug]Set output comment_id = xxx
##[debug]Set output initial_reaction_id = xxx
##[debug]Set output actor_handle = bzurkowski
##[debug]Set output actor = bzurkowski
##[debug]Finishing: Gate branch deployment

[GrantBirki]

@bzurkowski Hooray! Actually, looking at your logs and comment, since you had -d in your message... you were indeed also running into the same bug that has now been fixed!

This was the PR that fixed both your problem, and mine -> #187

Closing this issue out ✅