Giter Site home page Giter Site logo

Comments (7)

mlinksva avatar mlinksva commented on June 13, 2024

Some actions that may be useful, most stars first:

from government.github.com.

WebSnke avatar WebSnke commented on June 13, 2024

@mlinksva What exactly would resolve this problem? Changing the entry itself would break the link, right?

from government.github.com.

WebSnke avatar WebSnke commented on June 13, 2024

I'm going to leave open PRs that are failing the alphabetization test (which also can fail due to extra spaces, like this one) as motivation to fix #991 but feel free to make pass manually and I'll merge when you do.

The tests seem to fail when new countries are added...

from government.github.com.

mlinksva avatar mlinksva commented on June 13, 2024

The tests sometimes fail when new countries are added because extra spaces are present, probably when adding a new line the via the web editor which indents to the previous level.

- name: Ensure Orgs are sorted
run: |
bundle exec script/alphabetize
git diff --color --exit-code

The above sorts and overwrites the file, as a side effect without any extra spaces. It fails if diff has any output, whether from extra spaces or need to sort.

The idea would be to commit the overwritten file if there is any diff, and push that commit, autocorrecting a file that differs from the canonical (including sorted) output rather than failing and requiring manual fixup.

from government.github.com.

mlinksva avatar mlinksva commented on June 13, 2024

Hopefully just like this example https://github.com/marketplace/actions/add-commit#automated-linting

from government.github.com.

mlinksva avatar mlinksva commented on June 13, 2024

Nearly working in #1011 (comment)

from government.github.com.

WebSnke avatar WebSnke commented on June 13, 2024

The tests pass now in #1043.

from government.github.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.