Giter Site home page Giter Site logo

Comments (7)

cerw avatar cerw commented on May 30, 2024

I have same issue.

from hubot-scripts.

technicalpickles avatar technicalpickles commented on May 30, 2024

Confirmed this. It looks like the instance being iterated over doesn't have a tagSet, for whatever reason.

/cc @Iristyle

from hubot-scripts.

Iristyle avatar Iristyle commented on May 30, 2024

Oh hey -- I made that ;0

That's pretty peculiar actually -- this would mean that your EC2 instance doesn't have tag metadata.

Whenever you new up an instance with ec2-run-instances, you get one tag by default IIRC, name

So could you tell me if you have instances without tag metadata?

I could certainly mod the code to not scrape the name of the instance out if the tagSet is null -- seems odd though.

from hubot-scripts.

technicalpickles avatar technicalpickles commented on May 30, 2024

Thanks! Yeah, for my instances, there was no tag metadata. I'm not too savvy on EC2 things, but this might be an old old instance that doesn't have that.

Either way, it looks like it's definitely possible to not have a name tag. Maybe fall back to instanceId if it's not present?

from hubot-scripts.

Iristyle avatar Iristyle commented on May 30, 2024

Take a look at the proposed change.

I just slapped this together in Ace, as I don't have my Hubot install handy right now. Could you try it out locally?

Iristyle@875ec6f

from hubot-scripts.

Iristyle avatar Iristyle commented on May 30, 2024

@devdazed you want to give this a shot too? @cerw said this is a go for him.

If I had seen this sooner, I would have been on it.. but I don't monitor the bugtracker over here -- thanks @technicalpickles for bringing me in to the fold.

from hubot-scripts.

Iristyle avatar Iristyle commented on May 30, 2024

@devdazed you can close this...

from hubot-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.