Comments (6)
@piyushchordia-fis this integration works by Pull Requests
. It will validate all commits in the pull request, but it won't run just on a commit.
- Enable branch protection on your
main
,master
,feature**/**/*
andrelease**/**/*
- Open a pull request to the desired branch (with branch protection you cannot push directly to these branches without a pull request)
- The Rally integration will check all commit messages in that pull request and block the approval until each has a user story
Does that help?
from rally.
Thanks Jared for the response.
Are there any plans to integrate Commits also in future?
from rally.
@piyushchordia-fis what would be the desired functionality for commits? It will validate all commits in a pull request, but GitHub doesn't have any actions it takes on commits outside of a pull request. Are you wanting to block commits that don't have a valid user story in them? The current workflow for this app:
- Create branch
- Commit changes locally
- Push changes to branch in GitHub
- Open pull request
- App validates all commits
- if any commit is missing a user story, defect, etc, block the pull request
- if all commits are validated, allow this check to pass
In this scenario all commits are checked for all branches as they go through the flow. You could conceivably create a pre-receive hook that checks commits as they come it, but I wouldn't recommend that for a few reasons:
- pre-receive hooks only work on GHES (self-hosted, not github.com)
- pre-receive hooks have a non-configurable timeout of 5 seconds
- pre-receive hooks that depend on external systems often become blockers for productivity
from rally.
Thanks for sharing the details
I Agree, there wont be a commit without a PR .
But once we do commit in a branch there will be CI build triggered followed by auto deployment and testing.
In Rally there is an option in ChangeSet i.e Builds which will show Jenkins/CI Tool URL for that commit and also if there are Test cases if ran will be available in "Test Run" Tab.
This will be a end to end lifecycle of code committed on GITHUB.
from rally.
@piyushchordia-fis in this case there will be a connection in Rally under the Connections
tab which links back to this pull request. There is a ChangeSet API
that we can leverage to do something there, but I'm not quite sure how to tie in this bot with CI very easily from a workflow perspective. With Actions we could probably hook in and make this integration a part of the workflow, but with Jenkins, Travis, Circle, etc, we would need to to tailor this to each environment and have a dynamic way of hosting the app.
from rally.
Closing this one. @piyushchordia-fis if more clarity is needed please feel free to re-open this issue 🙇🏽
from rally.
Related Issues (20)
- Receiving octokit deprecation warning during start HOT 3
- bug report HOT 1
- Reg-ex issue with "S3" HOT 2
- Add Rally Connections every push to main HOT 1
- Optional checks HOT 1
- Updating a PR doesn't trigger rally check HOT 3
- PR with TA, TC, TF, or DS ID always fails HOT 4
- missing brackets? HOT 1
- Documentation around organization settings is inconsistent HOT 6
- Add Rally Body as part of the check HOT 1
- Add option to comment only once and edit previous comments HOT 2
- Ignore merge commits HOT 1
- Override seems to be in code, but how do you call it? HOT 8
- How to configure multiple rally work space? HOT 1
- Trying to resolve "connection reset by peer" on delivery issue HOT 1
- Application seems to be targeting an old version of the Github API HOT 1
- How can I have it sync issues with Rally? HOT 1
- Adds changesets to all Rally item references found HOT 1
- Leading and trailing underscores prevent the integration from recognizing valid rally artifacts HOT 1
- Hello world HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rally.