Giter Site home page Giter Site logo

Feature: Run checks on push event. about rally HOT 2 CLOSED

github avatar github commented on August 14, 2024
Feature: Run checks on push event.

from rally.

Comments (2)

primetheus avatar primetheus commented on August 14, 2024

@rrotaru this isn't really something we can implement outside of a pull request. We could trigger on the push event, but there would be no place to report anything without having a pull request. Ultimately the app would run, but would not be able to link anything in Rally (no PR) or provide feedback to the user (again, no PR). Ideally you should have a pull request drafted when you create the new branch, and then new pushes to that branch would be validated within that pull request. If you want to check commit messages as part of a pull request you simply set the rally.yml to validate commit messages. The title and body give additional ways to validate, but commit messages that are part of a PR can still be checked:

Config: https://github.com/github/rally/blob/main/rally.yml#L12
Code: https://github.com/github/rally/blob/main/lib/RallyValidate.js#L376-L401

from rally.

rrotaru avatar rrotaru commented on August 14, 2024

Makes sense. Closing this issue, thanks for the reply @primetheus!

from rally.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.