Giter Site home page Giter Site logo

Comments (9)

gdubicki avatar gdubicki commented on June 23, 2024 1

I think that you misunderstood me: it's already implemented in gitlabform and I did it was when this API was not yet deprecated. :)

from gitlabform.

gdubicki avatar gdubicki commented on June 23, 2024 1

Sadly I don’t have time to develop this myself currently, but we are open to accepting PRs with this.

from gitlabform.

therealgambo avatar therealgambo commented on June 23, 2024 1

@gsemet - Ive implemented protected tag functionality in #39

from gitlabform.

gdubicki avatar gdubicki commented on June 23, 2024

gitlabform has support for older, now deprecated API for protecting branches, see https://github.com/egnyte/gitlabform/blob/master/config.yml#L90 .

from gitlabform.

born4new avatar born4new commented on June 23, 2024

If it's deprecated, I don't think it's a great idea for us to start using it :).

from gitlabform.

gdubicki avatar gdubicki commented on June 23, 2024

Note to self: when implementing this we should take #10 into account.

from gitlabform.

born4new avatar born4new commented on June 23, 2024

Any news on that one?

Also, I now realize that I haven't replied to your comment:

I think that you misunderstood me: it's already implemented in gitlabform and I did it was when this API was not yet deprecated. :)

Point being that we would like to be able to configure protected branches in a non-deprecated way according to GitLab :).

from gitlabform.

gsemet avatar gsemet commented on June 23, 2024

"Protected tag" as well?

from gitlabform.

gdubicki avatar gdubicki commented on June 23, 2024

Note to self: we can implement this feature as:

  • replacement for the current way of managing branch protection, including different syntax - this would require major version uptick,
  • adding new way next to the old way with making the old one use the new API under the hood.

Of course the 2nd is more user-friendly but because we have too little maintainers of this app I would prefer the 1st as it requires less maintenance.

We can prevent the app from running ONLY IF user is using branch protection config and does not declare the config to be compatible with GitLabForm v. 2.*.

After we implement new approvers API in #68 we will probably have to do the same.

Ideally we should do both of these changes together to have only a single major version uptick here.

While creating v.2 we can think about more config syntax improvements. Let's discuss them in a separate issue.

from gitlabform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.