Comments (9)
I think that you misunderstood me: it's already implemented in gitlabform and I did it was when this API was not yet deprecated. :)
from gitlabform.
Sadly I don’t have time to develop this myself currently, but we are open to accepting PRs with this.
from gitlabform.
@gsemet - Ive implemented protected tag functionality in #39
from gitlabform.
gitlabform has support for older, now deprecated API for protecting branches, see https://github.com/egnyte/gitlabform/blob/master/config.yml#L90 .
from gitlabform.
If it's deprecated, I don't think it's a great idea for us to start using it :).
from gitlabform.
Note to self: when implementing this we should take #10 into account.
from gitlabform.
Any news on that one?
Also, I now realize that I haven't replied to your comment:
I think that you misunderstood me: it's already implemented in gitlabform and I did it was when this API was not yet deprecated. :)
Point being that we would like to be able to configure protected branches in a non-deprecated way according to GitLab :).
from gitlabform.
"Protected tag" as well?
from gitlabform.
Note to self: we can implement this feature as:
- replacement for the current way of managing branch protection, including different syntax - this would require major version uptick,
- adding new way next to the old way with making the old one use the new API under the hood.
Of course the 2nd is more user-friendly but because we have too little maintainers of this app I would prefer the 1st as it requires less maintenance.
We can prevent the app from running ONLY IF user is using branch protection config and does not declare the config to be compatible with GitLabForm v. 2.*.
After we implement new approvers API in #68 we will probably have to do the same.
Ideally we should do both of these changes together to have only a single major version uptick here.
While creating v.2 we can think about more config syntax improvements. Let's discuss them in a separate issue.
from gitlabform.
Related Issues (20)
- [Bug] - Duplicate Pipeline schedules HOT 2
- Breaking Inheritance HOT 4
- Add `enforce` support to schedule pipeline config HOT 1
- How do you create an environment? HOT 2
- How to add users ONLY to top-level group? HOT 8
- Project API: public_jobs versus public_builds HOT 2
- Breaking Inheritance not working in branches section HOT 1
- Issue with Merge Request Rules for specific branches HOT 2
- Support for SAML group links HOT 1
- Group membership fails to apply when using keep_bots attribute HOT 5
- Usernames in projects and groups should be case-insensitive HOT 3
- `enforce_keep_bots` test intermittently fails in the GitHub CI
- Manage CI/CD job token scope allowlist HOT 9
- Remove support for python 3.7 and possibly other older versions HOT 10
- How to set merge_method option for a project HOT 2
- Gitlab 16.x: cannot update settings of archived projects HOT 13
- Skipping Nested Projects/groups ? HOT 7
- Direct membership to all projects under a group to get CODEOWNERS MR approval to work HOT 3
- Add Support for External Status Checks HOT 6
- Should we remove mypy type checking or validation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitlabform.