Giter Site home page Giter Site logo

Comments (6)

hertzsprung avatar hertzsprung commented on August 24, 2024 1

Makes sense, thanks. I'll get back to you next week with a config syntax proposal that accommodates #607 and #571. If we're happy I'll try to find time to contribute, too.

from gitlabform.

TimKnight-DWP avatar TimKnight-DWP commented on August 24, 2024 1

@amimas @hertzsprung changes to support this are here: TimKnight-DWP#1

Currently on my fork only because I need to point at my fork of python-gitlab to pick up that part of the chain. Everything is capable of being merged when gitlab 16.10 gets released, so I'll update the MR to point back to mainline python-gitlab when this MR goers in python-gitlab/python-gitlab#2816.

However a review of the proposed changes would be great if possible :)

from gitlabform.

amimas avatar amimas commented on August 24, 2024

Hello. I believe this is same/duplicate of issue #571 . Could you please confirm?

from gitlabform.

hertzsprung avatar hertzsprung commented on August 24, 2024

It's closely related, feel free to combine the two issues if appropriate. But the PATCH request only sets a boolean flag for the project, it doesn't allow fine grained control provided by the allowlist.

from gitlabform.

amimas avatar amimas commented on August 24, 2024

the PATCH request only sets a boolean flag for the project,

Thanks for clarifying. I think it's fine for this to be a separate issue. Can be implemented without everything related to job token being involved. Keeps the scope small.

PRs are welcome. Would you be able to help contribute this feature? Do you have a proposal for the config syntax?

from gitlabform.

amimas avatar amimas commented on August 24, 2024

That sounds great!! Thanks.

from gitlabform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.