Giter Site home page Giter Site logo

Comments (6)

gdubicki avatar gdubicki commented on June 23, 2024 1

Hi @Dridge !

gitlabform just goes through each service defined in this config sections and makes PUT requests to GitLab API. So both password change and commit events change flag flip should work.

But I have checked that and it seems that there is a bug in GitLab API that makes those PUT requests not work, at least for JIRA service.

We could try a workaround of deleting and recreating services with API on each gitlabform run but I am afaid of the side effects (and a bit about performance). I have quickly tried making a diff between current and target service config (or, to be precise, a check for target config being subset of the current config) to check if a PUT request is needed but for example for Jira service the GitLab API does not return password in response (which make sense, of course) what makes this diffing ineffective. Maybe we should make this "always recreate services" a default off feature (or rather a workaround)?

from gitlabform.

Dridge avatar Dridge commented on June 23, 2024

Maybe we should make this "always recreate services" a default off feature

This sounds reasonable to me, and the only way to get around the gitlab api bug.

from gitlabform.

gdubicki avatar gdubicki commented on June 23, 2024

My new integrations tests (see link above) confirm that there is this problem, most probably with all services (I tested using the first one alphabetically, asana).

from gitlabform.

gdubicki avatar gdubicki commented on June 23, 2024

I noted in https://gitlab.com/gitlab-org/gitlab/-/issues/202216 that the password field is not being updated too.

from gitlabform.

gdubicki avatar gdubicki commented on June 23, 2024

I have just released v1.13.4 with the "recreate" flag mentioned a few comments above.

See this example config section for info how to use it: https://github.com/egnyte/gitlabform/blob/master/config.yml#L179-L183

Please let me know if this helps, @Dridge .

from gitlabform.

gdubicki avatar gdubicki commented on June 23, 2024

Thanks to Vincent Bisserié's help (if you are reading this - thank you!) I fixed the root cause and released v1.13.5 where this issue should be completely resolved without any workarounds.

Please reopen this issue if it does not help you, @Dridge .

from gitlabform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.