gitdiff report "parser" can cause an infinite wait on parser error

[groboclown]

gitdiff report "parser" can cause an infinite wait on parser error

[groboclown]

One possible fix is to change the NewGitDiffCmd function to call the parser like:

errCh := make(chan error)
go listenForStdErr(stderr, errCh)

gitdiffFiles, err := gitdiff.Parse(stdout, errCh)

and change the Parse to accept the error channel, and change the on-error return to now send the error to the error channel + return.

Unfortunately, this is a backwards-incompatible change for the go-gitdiff command.

[groboclown]

Along with this, it looks like the DetectGit function's case err, open := <-errCh can cause the function to hang unless the d.Sema is dealt with.

[zricethezav]

@groboclown thanks for bringing up this issue. Do you have a repo I can test with?

[groboclown]

@zricethezav Unfortunately, I have not been able to trace the actions that lead to this behavior. I was seeing it with a complicated private repository. If I could find the way to generate it, it would also lead to a better bug report to the Git folks.