Giter Site home page Giter Site logo

Comments (6)

behe avatar behe commented on June 23, 2024 1

Maybe just document what to put in compile if it's missing in the installation instructions?

from heroku-buildpack-phoenix-static.

jbrowning avatar jbrowning commented on June 23, 2024

The root issue here of course is that older default Phoenix package.json files did not contain a deploy script. We're old school. :)

from heroku-buildpack-phoenix-static.

gjaldon avatar gjaldon commented on June 23, 2024

Maybe we can do a check to see if brunch or webpack is used and then run the corresponding script? For the meantime, you can add a custom compile file to override the default compile commands. You can refer here https://github.com/gjaldon/heroku-buildpack-phoenix-static#compile

from heroku-buildpack-phoenix-static.

jaimeiniesta avatar jaimeiniesta commented on June 23, 2024

Same here, on a phoenix 1.4 app that still uses brunch:

remote: sent 60 bytes  received 19 bytes  158.00 bytes/sec
remote: total size is 0  speedup is 0.00
remote:        Running default compile
remote:        npm ERR! missing script: deploy
remote:
remote:        npm ERR! A complete log of this run can be found in:
remote:        npm ERR!     /app/.npm/_logs/2019-03-08T15_00_27_106Z-debug.log
remote:  !     Push rejected, failed to compile Phoenix app.
remote:
remote:  !     Push failed

from heroku-buildpack-phoenix-static.

gjaldon avatar gjaldon commented on June 23, 2024

The README has been updated to explain that default compile has been changed and includes what needs to be put in compile https://github.com/gjaldon/heroku-buildpack-phoenix-static#faq

Let me know if this is good enough or needs some changes.

from heroku-buildpack-phoenix-static.

jbrowning avatar jbrowning commented on June 23, 2024

Good enough for me.

Many thanks.

from heroku-buildpack-phoenix-static.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.