Working on Koa2?

[0cv]

Working on Koa2?

[0cv]

Got it thank you @glenjamin. My mistake was to register the middleware straight (I did the require, then app.use) instead of wrapping the require into a function inside app.use like you did). I will close the issue, may that help someone else! Thanks again.

[glenjamin]

The other part that makes it work is doing a require inside the main HTTP handler. Can you post a sample?

[0cv]

I have added that in the server part:

const watcher = chokidar.watch(`${__dirname}/..`);

watcher.on('ready', function() {
  watcher.on('all', function() {
    console.log('Clearing /server/ module cache from server');
    Object.keys(require.cache).forEach(function(id) {
      if (/[\/\\]server[\/\\]/.test(id) && !(/[\/\\]bin[\/\\]/.test(id)) && !(/[\/\\]models[\/\\]/.test(id))) {
        console.log('delete', id)
        delete require.cache[id]
        require(id)
      }
    });
  });
});

=> I exclude the bin folder where the server is located, also the models, because mongoose complains when the model is recreated twice, fair enough.

I have also added explicitly a require(id) after deleting from the cache, otherwise the next time it's run, somehow, the modules are not required again (could be already one problem why I need to do that...)

I should mention I'm using babel with babel-register and ES6 import/export. I've seen, they are somehow caching modules too http://babeljs.io/docs/usage/require/, but I've disabled the cache like mentioned (I have also tried to delete the json file created to force a refresh). Both options didn't change anything.

Below is the structure of the server folder where we can see the bin folder and models folder (both ignored):

For my tests, I changed the value in the console.log and then refreshed the browser to trigger the route. The value shown in the console is (of course) correct the first time the app is started, but not for any subsequent edit to the console.log.

[glenjamin]

I think doing the require(id) inside that loop isn't going to work, as you'll be partially repopulating the cache as you're clearing it.

You need to clear it out entirely, and let the next incoming route repopulate it.

[0cv]

You're right. I could narrow down the issue to app.use. Something modified outside of Koa feels like to work, but not in Koa. In your version, the middleware is somehow overwritten, but not in my app where even so I do a new app.use with the fresh route, it still keep the previous version. Will try to see/figure out how to deregister/update a middleware...

[glenjamin]

Here: https://github.com/glenjamin/ultimate-hot-reloading-example/blob/master/server.js#L28-L31

The middleware here delegates to the real middleware which is "late bound", it always requires the real middleware and passes all the arguments through.

You'll need something like that.