Giter Site home page Giter Site logo

Safe Decode? about bs-json HOT 5 CLOSED

glennsl avatar glennsl commented on June 15, 2024
Safe Decode?

from bs-json.

Comments (5)

glennsl avatar glennsl commented on June 15, 2024 1

Hi. What do you mean you can't catch the exception? Have you tried adding a branch for DecodeError to the try block?

      try (decodeState(Json.parseOrRaise(stateStr))) {
        | Json.ParseError(e) => ...
        | Json.Decode.DecodeError(e) => ...
      };

should work fine.

from bs-json.

raqystyle avatar raqystyle commented on June 15, 2024

@glennsl Json.Decode.DecodeError is what I was missing. Thank you! But I didn't know I had to add this branch as well. The compiler didn't argue back that my check is not exhaustive enough. I'm I missing something?

from bs-json.

raqystyle avatar raqystyle commented on June 15, 2024

@glennsl Actually, I was mislead (maybe, this word is too strong) by the documentation for the Json.parseOrRaise which states: parse s returns a Js.Json.t if s is a valid json string, raises ParseError otherwise. Anyway, thank you for the help!

from bs-json.

glennsl avatar glennsl commented on June 15, 2024

There's unfortunately no exhaustiveness checking for exceptions. Parsing and decoding are different processes, and you need to check for errors from both. It can be a valid json string and still not fit the shape you need, in which case it will raise a DecodeError.

There are libraries that do provide exhaustiveness checking of errors, like JsonR and JsonCodec, but it comes at a cost.

from bs-json.

raqystyle avatar raqystyle commented on June 15, 2024

@glennsl Oh, I see. Thank you for explanation!

from bs-json.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.