Improve stacked_bar.py

[gruebel]

Improve stacked_bar.py

[gruebel]

3. Python uses snake_case for variable names
   

   cost-reporter/cost-reporter/src/stacked_bar.py

   Line 25 in f15d3fd

   barWidth = 0.5

[gruebel]

4. List comprehension is not needed here
   

   cost-reporter/cost-reporter/src/stacked_bar.py

   Line 28 in f15d3fd

   bottom = [0 for x in r]

bottom = [0] * days

[gruebel]

5. Instead of using a separate index variable (x)
   

   cost-reporter/cost-reporter/src/stacked_bar.py

   Lines 30 to 39 in f15d3fd

   	x = 0
   	for label in all_bars.keys():
   	# There is nothing below the first bar, skip it for the first iteration
   	if x > 0:
   	print(previous_bar)
   	bottom = np.add(bottom, previous_bar).tolist()
   	plt.bar(r, all_bars[label], bottom=bottom, color=COLORS[x], edgecolor=edgecolor, width=barWidth, label=label)
   	x += 1
   	previous_bar = all_bars[label]

   
   it can be done with enumerate()

    for idx, label in enumerate(all_bars.keys()):
        # There is nothing below the first bar, skip it for the first iteration
        if idx > 0:
            print(previous_bar)
            bottom = np.add(bottom, previous_bar).tolist()

        plt.bar(r, all_bars[label], bottom=bottom, color=COLORS[idx], edgecolor=edgecolor, width=barWidth, label=label)
        previous_bar = all_bars[label]

[gruebel]

6. if this should be really logged, then use proper logging
   

   cost-reporter/cost-reporter/src/stacked_bar.py

   Line 34 in f15d3fd

   print(previous_bar)

[gruebel]

7. it is always better to use pathlib module to define a filesystem path to make it OS independent
   

   cost-reporter/cost-reporter/src/stacked_bar.py

   Line 53 in f15d3fd

   plt.savefig('/tmp/image.png', bbox_inches='tight')

[flyck]

done, thanks